[KDE/Mac] Building Bovo (was Slowdown :))

[Ian Wadham]

Hi Marko,

On 14/09/2014, at 6:12 PM, Marko Käning wrote:
> On 14 Sep 2014, at 09:32 , Ian Wadham <iandw.au at gmail.com> wrote:
>> But before you go, did you finally succeed in building Bovo?
> 
> Ian, as I responded to Albert’s reply, I did not receive any email
> from you directly and I am not subscribed to the kdegames list, yet.
> Should I?

This is nothing to do with the KDE Games list.  I did not write there on
this topic.  I think my replies may have got lost because your thread
"OSX/CI: bovo fails to build on branch frameworks" was on
kde-frameworks-devel at kde.org and I am not subscribed to that.

Never mind. "Once more into the breach, dear friends, once more!"

I am putting this on the KDE-Mac list in case Rene or Nicolas has an
input. See also [1]. I think you just need to get rid of C++11 flags in
the compile. Marko wrote:

        But bovo still has problems:
        ----
        /Users/marko/WC/KDECI-builds/bovo/ai/aron/aiboard.cc:450:11: error: non-constant-expression cannot
        be narrowed from type 'int' to 'usi' (aka        'unsigned short') in initializer list [-Wc++11-narrowing]
         LEFT | UP,
         ^~~~~~~~~
        /Users/marko/WC/KDECI-builds/bovo/ai/aron/aiboard.cc:450:11: note: override this message by inserting an explicit cast
         LEFT | UP,
         ^~~~~~~~~
         static_cast<usi>( )
        ----
        I attached the full log.

I read that, and the log, and replied, at 00:40 AM UTC on 12 September (10::40 my time):

        The errors are on the log are all the same.  It does not like <usi> | <usi> (type int?)
        going to <usi> type.  Are you using C++11?  See "[-Wc++11-narrowing]"above.

        What does KDE software usually use?  The KDE devs are not changing over
        to C++11, are they?…  If they are, nobody told us on KDE Games… :-(

        "usi" is a typedef defined in the Bovo file "game/common.h", an alias for
        "unsigned short int". 

        I built Bovo OK on my KDE Games test setup: AppleClang 4.2.0.4250024,
        KDE 4, Bovo master branch, with very simple CMake options.  So maybe
        you do have C++11 compiler options messing things up.  IANAEOC++11
        (I am not an expert on C++11), but there has been some discussion of
        it recently on MacPorts lists (actually the first time I ever heard of it… :-)).

Oh, I am pretty sure KDE developers are NOT changing to C++11, judging by the
logs of compiles and builds of Bovo I saw later from *Linux* Jenkins CI.

Cheers, Ian W.

[1] The context of the error message above, in bovo/ai/aron/aiboard.cc, is:

    usi LEFT = 1;
    usi UP = 2;
    usi RIGHT = 4;
    usi DOWN = 8;
    usi DIR[8] = {
          LEFT,
          RIGHT,
          UP,
          DOWN,
          LEFT | UP,                   // NOTE: This is the line where the error occurs.
          RIGHT | DOWN,
          LEFT|DOWN,
          RIGHT|UP
    };