[KDE/Mac] Upgrade to 4.13.3 in Macports

[Ian Wadham]

Hi Nicolas,

On 13/09/2014, at 6:50 PM, Nicolas Pavillon wrote:
> I have been pretty backlogged during the past weeks, but I am gradually getting back to it, and am planning to upgrade KDE on Macports to 4.13.3. 

Great news!  But how long have I got to polish up my patches? Days? A week or two?

> As there has been quite some work done, I would gladly take some feedback on what to integrate in the upgrade. For the sake of stability, I would tend to focus on the upgrade itself and possibly some patches, but perhaps not adding too much features at once, in order to ease problem identification if/when failure reports come from users. 
> 
> The main changes that I would include in 4.13.3 are:
> - Review of all dependencies, in order to make several implicit ones now explicit
> - Addition of ports baloo (baloo and baloo-widgets). There are not used automatically for now, but a variant is added to nepomuk-core and kde4-baseapps to include the dependency. Kdepim4 also requires baloo, as it can’t compile without it, but it would not be activated. As it would not be readily used for now, the nepomuk dependency would be kept. There are also probably some services to take care of before baloo could really be used. 
> - The patch of René to avoid a crash from kwindow (https://reviewboard.kde.org/r/119240/). This one is already committed in KDE 4.14, so it seems logical to add it at once.
> 
> There are then some patches that I would consider rather safe to include:
> - Use of OSX keychain (https://git.reviewboard.kde.org/r/119838/) This seems like a nice feature, with its use based on a variant, which would thus be mainly “on demand”. 
> 
> In addition to these, there are then several patches, where I am not sure if they should be included at once, or left out for now and included later.
> - KCrash and Dr. Konqi (https://git.reviewboard.kde.org/r/119497/ and	https://git.reviewboard.kde.org/r/119498/). There has been apparently quite some debate, and apparently, Ian, you are still working on a more elaborate solution for this problem, right? Therefore, should the present patches be used in the meantime, or are they not yet mature enough?

I could give you some patches fairly soon that would at least ensure that KCrash
and Dr Konqi will *run* on Apple OS X without themselves crashing.  At the worst,
Dr K might disconnect from bugs.kde.org before the user can finish off and submit
the complete bug report, but he/she can still save it and the backtrace report will
be useful to MacPorts and KDE-Mac devs at least.

Unfortunately, Bugzilla changed its software in July and no longer accepts cookies.
I am working on some changes for Dr K to use the new security-checking regime.

> - Native file dialogs (https://reviewboard.kde.org/r/119243/). This seems to be deeper changes, that I would tend to leave out for now in order to see how 4.13 is going first.

What René says is fine by me.  But I would not put the patch in as a variant, just put
it in… :-)  It is not perfect, but it is a great improvement.

We now know that KFileDialog is to be discontinued in KF5 and replaced by QFileDialog,
which is always native.  I think a better patch would be to divert the half-dozen or so relevant
KFileDialog methods to invoke QFileDialog on Apple OS X.  I was thinking of working on
that when I have some time.

Cheers, Ian W.

> - System trays menus (​https://reviewboard.kde.org/r/120149/). Again, these would be changes I would leave out for now to test 4.13 first.
> 
> There are also some proposed changes in kdepim4, but I did not look at them yet. 
> 
> Any input welcome on this, would it be about the patches above, or something else I may have missed.