[Kde-imaging] printwizard issue

[Gilles Caulier]

2008/11/4 Angelo Naselli <anaselli at linux.it>

> On Monday 03 November 2008 23:24:06 Andi Clemens wrote:
> > Well I cleaned up the includes because Gilles asked me to. Nothing is
> > broken and no code has been removed. If includes are missing while
> > completing the porting, it is easy to add them again :-) But I guess most
> > of them where not used or the includes where double (declared in header
> > files and CPP files). Also some includes that should been added where not
> > added, which could be seen when putting the own include files on top of
> the
> > include chain.
> > Wizard.cpp and another file that I can't remember now had not their own
> > header files included, so actually this clean up wasn't that wrong.
> Well it seemed odd to me that the same file somewhere else it was
> untouched....
> There's no problem in cleaning files, but you removed kdebug for instance,
> maybe i still needed in this phase. And even if this time there were no
> problems, as soon as i saw all those changes i was afraid of a merge and
> time
> is too important for me right now....
>
> > If you think it was bad, we can revert it again.
> no i can add again what i need to, but some includes were added from
> starting
> file in which i had a lot of code to move yet.
>
> > Also why not enable it in CMakeLists? This is trunk and as long as it
> Easy, because i don't want it to go in a beta yet. Why? it isn't a print
> assistant yet, but only a dialog...
>

It's not a problem. I know status of printwizzard code, and i will disable
it before to release next beta...

Gilles
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-imaging/attachments/20081104/830da5a8/attachment.htm