<br><br><div class="gmail_quote">2008/11/4 Angelo Naselli <span dir="ltr"><<a href="mailto:anaselli@linux.it">anaselli@linux.it</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">On Monday 03 November 2008 23:24:06 Andi Clemens wrote:<br>
> Well I cleaned up the includes because Gilles asked me to. Nothing is<br>
> broken and no code has been removed. If includes are missing while<br>
> completing the porting, it is easy to add them again :-) But I guess most<br>
> of them where not used or the includes where double (declared in header<br>
> files and CPP files). Also some includes that should been added where not<br>
> added, which could be seen when putting the own include files on top of the<br>
> include chain.<br>
> Wizard.cpp and another file that I can't remember now had not their own<br>
> header files included, so actually this clean up wasn't that wrong.<br>
</div>Well it seemed odd to me that the same file somewhere else it was<br>
untouched....<br>
There's no problem in cleaning files, but you removed kdebug for instance,<br>
maybe i still needed in this phase. And even if this time there were no<br>
problems, as soon as i saw all those changes i was afraid of a merge and time<br>
is too important for me right now....<br>
<div class="Ih2E3d"><br>
> If you think it was bad, we can revert it again.<br>
</div>no i can add again what i need to, but some includes were added from starting<br>
file in which i had a lot of code to move yet.<br>
<div class="Ih2E3d"><br>
> Also why not enable it in CMakeLists? This is trunk and as long as it<br>
</div>Easy, because i don't want it to go in a beta yet. Why? it isn't a print<br>
assistant yet, but only a dialog...<br>
<div class="Ih2E3d"></div></blockquote><div><br>It's not a problem. I know status of printwizzard code, and i will disable it before to release next beta...<br><br>Gilles</div></div><br>