[Kde-imaging] printwizard issue

[Angelo Naselli]

On Monday 03 November 2008 23:24:06 Andi Clemens wrote:
> Well I cleaned up the includes because Gilles asked me to. Nothing is
> broken and no code has been removed. If includes are missing while
> completing the porting, it is easy to add them again :-) But I guess most
> of them where not used or the includes where double (declared in header
> files and CPP files). Also some includes that should been added where not
> added, which could be seen when putting the own include files on top of the
> include chain.
> Wizard.cpp and another file that I can't remember now had not their own
> header files included, so actually this clean up wasn't that wrong.
Well it seemed odd to me that the same file somewhere else it was
untouched....
There's no problem in cleaning files, but you removed kdebug for instance, 
maybe i still needed in this phase. And even if this time there were no
problems, as soon as i saw all those changes i was afraid of a merge and time 
is too important for me right now....

> If you think it was bad, we can revert it again.
no i can add again what i need to, but some includes were added from starting
file in which i had a lot of code to move yet.

> Also why not enable it in CMakeLists? This is trunk and as long as it
Easy, because i don't want it to go in a beta yet. Why? it isn't a print
assistant yet, but only a dialog...

>My removeredeyes batch plugin is also far from good, but I added and enabled 
>it
Maybe you don't mind having useless bug reports :p

> Anyway I apologize for cleaning up the includes if that really bothered you
> that much. Next time I will ask :-)
I usually don't mind if people fix my problems ;) Anyway it's a good use to
talk to maintainers first...

Cheers,
-- 
Angelo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-imaging/attachments/20081104/92b0dd26/attachment.sig