[Kde-imaging] Ugly hack for am_edit for libkdcraw-ABI_MAJOR.mo

[Achim Bohnet]

On Friday, 15. June 2007, Angelo Naselli wrote:
> Alle mercoledì 13 giugno 2007, Achim Bohnet ha scritto:
> > Hi,
> > I've tested the patch with 0.1.0.   It's quite ugly
> > because it appends -ABI_MAJOR unconditionally and
> > admin/am_edit needs to be patched.
> > 
> > Maybe kde-core-devel has better ideas.
> > 
> > Now missing is on of:
> > 
> > a) were to add the insertCatalog(LIBKDCRAW_CATALOG) method
> >    in the library and add to Makefile.am
> >    KDE_CXXFLAGS=-DLIBKDCRAW_CATALOG='"libkdcraw-$(ABI_VERSION)"'
> > b) add LIBKDCRAW_CATALOG to version.h.in  and let the apps
> >    load the catalog
> > c) add insertLibkdcrawCatalog() helper method
> > d) ...
> > 
> > my favorite is a) because apps using libkdcraw don't have to
> > care about the catalog.
> > 
> > Achim
> > 
> Achim your patch to have $libdir/libkdcraw1/kdcraw does not work with 
> rpm (i said i don't like changing bindir into makefile) the reason is
> to be found on fake installation:

Debian uses fake installations too to build the deb since it's birth.
Instead of / it's $source_dir/debian/tmp/  No problem with libkdcraw1

    make DESTDIR=$source_dir/debian/tmp/ install

> [anaselli at seggie dcraw]$ rpm --eval "%makeinstall"
>                                                                                   make \                                                                                prefix=/home/anaselli/rpm/tmp//%{name}-root/usr \                               exec_prefix=/home/anaselli/rpm/tmp//%{name}-root/usr \                          bindir=/home/anaselli/rpm/tmp//%{name}-root/usr/bin \                           sbindir=/home/anaselli/rpm/tmp//%{name}-root/usr/sbin \                         sysconfdir=/home/anaselli/rpm/tmp//%{name}-root/etc \                           datadir=/home/anaselli/rpm/tmp//%{name}-root/usr/share \                        includedir=/home/anaselli/rpm/tmp//%{name}-root/usr/include \                   libdir=/home/anaselli/rpm/tmp//%{name}-root/usr/lib64 \
>         libexecdir=/home/anaselli/rpm/tmp//%{name}-root/usr/lib64 \
>         localstatedir=/home/anaselli/rpm/tmp//%{name}-root/var/lib \
>         sharedstatedir=/home/anaselli/rpm/tmp//%{name}-root/usr/com \
>         mandir=/home/anaselli/rpm/tmp//%{name}-root/usr/share/man \
>         infodir=/home/anaselli/rpm/tmp//%{name}-root/usr/share/info \
>   install
> bindir=/home/anaselli/rpm/tmp//%{name}-root/usr/bin \  

WTF is rpm doing?  Sorry ;)

	make DESTDIR=/inst/to/this/path install

is the recommended and right way since auto* tools are written and
before linux was invented.

> so it's installed in $buildroot/usr/bin :(

that what one get's when one uses var for stuff they were never
designed for :(

> and then in /usr/bin into the binary package.
> I'll try to patch my soec file for this release but
> we need a better solution 

Slap rpm until it RTFM :)

Seriously:  Either tweak rpm to only use simply use only
DESTDIR or mv the bin in the spec to the right dir, or,
well, argl, shudder fix a hack with another hack and
use the install-hooks ;)

Achim
> Cheers,
> 	Angelo
> 



-- 
  To me vi is Zen.  To use vi is to practice zen. Every command is
  a koan. Profound to the user, unintelligible to the uninitiated.
  You discover truth everytime you use it.
                                      -- reddy at lion.austin.ibm.com