[Kde-imaging] Ugly hack for am_edit for libkdcraw-ABI_MAJOR.mo

[Angelo Naselli]

Alle mercoledì 13 giugno 2007, Achim Bohnet ha scritto:
> Hi,
> I've tested the patch with 0.1.0.   It's quite ugly
> because it appends -ABI_MAJOR unconditionally and
> admin/am_edit needs to be patched.
> 
> Maybe kde-core-devel has better ideas.
> 
> Now missing is on of:
> 
> a) were to add the insertCatalog(LIBKDCRAW_CATALOG) method
>    in the library and add to Makefile.am
>    KDE_CXXFLAGS=-DLIBKDCRAW_CATALOG='"libkdcraw-$(ABI_VERSION)"'
> b) add LIBKDCRAW_CATALOG to version.h.in  and let the apps
>    load the catalog
> c) add insertLibkdcrawCatalog() helper method
> d) ...
> 
> my favorite is a) because apps using libkdcraw don't have to
> care about the catalog.
> 
> Achim
> 
Achim your patch to have $libdir/libkdcraw1/kdcraw does not work with 
rpm (i said i don't like changing bindir into makefile) the reason is
to be found on fake installation:
[anaselli at seggie dcraw]$ rpm --eval "%makeinstall"
                                                                                  make \                                                                                prefix=/home/anaselli/rpm/tmp//%{name}-root/usr \                               exec_prefix=/home/anaselli/rpm/tmp//%{name}-root/usr \                          bindir=/home/anaselli/rpm/tmp//%{name}-root/usr/bin \                           sbindir=/home/anaselli/rpm/tmp//%{name}-root/usr/sbin \                         sysconfdir=/home/anaselli/rpm/tmp//%{name}-root/etc \                           datadir=/home/anaselli/rpm/tmp//%{name}-root/usr/share \                        includedir=/home/anaselli/rpm/tmp//%{name}-root/usr/include \                   libdir=/home/anaselli/rpm/tmp//%{name}-root/usr/lib64 \
        libexecdir=/home/anaselli/rpm/tmp//%{name}-root/usr/lib64 \
        localstatedir=/home/anaselli/rpm/tmp//%{name}-root/var/lib \
        sharedstatedir=/home/anaselli/rpm/tmp//%{name}-root/usr/com \
        mandir=/home/anaselli/rpm/tmp//%{name}-root/usr/share/man \
        infodir=/home/anaselli/rpm/tmp//%{name}-root/usr/share/info \
  install
bindir=/home/anaselli/rpm/tmp//%{name}-root/usr/bin \  
so it's installed in $buildroot/usr/bin :(
and then in /usr/bin into the binary package.
I'll try to patch my soec file for this release but
we need a better solution 

Cheers,
	Angelo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-imaging/attachments/20070615/9b7f6fd5/attachment.pgp