[Kde-imaging] [PATCH] improvements to uploadwidget.cpp

Angelo Naselli anaselli at linux.it
Mon Sep 25 19:03:04 CEST 2006


Alle 18:43, lunedì 25 settembre 2006, Aurélien Gâteau ha scritto:
> 
> On 25/9/2006, "Angelo Naselli" <anaselli at linux.it> wrote:
> >> I will test your patch tomorrow morning using digiKam like host
> > right three tell us ok. So why not to commit them?
> 
> I would feel better about it if Gilles approves them :-)
> 
> > A question though does this commit break something in host applications?
> 
> The only point where it could break is that I changed the signature of a
> protected slot from load() to load(KFileTreeViewItem*). This would cause
> errors in plugins if they inherited from UploadWidget and try to call
> load() from the inherited class.
> If that is a problem I can probably implement a fully binary safe version.
As far as i can say we can also break it and release a new version.
Since we've wrongly released libkipi version.... ;)

Angelo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-imaging/attachments/20060925/95c0d0d9/attachment.pgp 


More information about the Kde-imaging mailing list