[Kde-imaging] [PATCH] improvements to uploadwidget.cpp

[Gilles Caulier]

On Monday 25 September 2006 12:30, Aurélien Gâteau wrote:
> Hello,
>
> I finally got annoyed with UploadWidget not expanding his treeview to the
> uploadPath and patched it.
>
> Here is the description of the attached patches:
> - uploadwidget_renaming.diff
>   Just some renaming before the real work, essentially naming
> 'KFileTreeBranch' as 'branch' and 'KFileTreeViewItem' as 'item'
>
> - uploadwidget_open_upload_path.diff
>   The real work: reworked tree expanding. Works with Gwenview, didn't
> try it with other apps.
>
> - uploadwidget_hide_header.diff
>   A very simple patch to remove the treeview header line, saving some
> valuable vertical space.

I'm agree with this one.

>
> Ok to commit?
>
> Aurélien

Using a fresh svn checkout of libkipi, patching failed :

[libkipi]$ patch -p0 < uploadwidget_hide_header.diff
patching file libkipi/uploadwidget.cpp
Hunk #1 succeeded at 86 (offset 1 line).
[libkipi]$ patch -p0 < uploadwidget_open_upload_path.diff
patching file libkipi/uploadwidget.cpp
Hunk #1 succeeded at 53 with fuzz 2.
Hunk #2 FAILED at 105.
Hunk #3 FAILED at 124.
Hunk #4 FAILED at 137.
Hunk #5 FAILED at 156.
4 out of 5 hunks FAILED -- saving rejects to file libkipi/uploadwidget.cpp.rej
patching file libkipi/uploadwidget.h
[libkipi]$ patch -p0 < uploadwidget_renaming.diff
patching file libkipi/uploadwidget.cpp
Hunk #1 succeeded at 51 with fuzz 2.
Hunk #2 succeeded at 78 (offset -1 lines).
[libkipi]$     

Gilles