[Kde-imaging] [PATCH] improvements to uploadwidget.cpp

[Aurelien Gateau]

Le Lundi 25 Septembre 2006 18:48, Caulier Gilles a écrit :
> Le Lundi 25 Septembre 2006 18:43, Aurélien Gâteau a écrit :
> > On 25/9/2006, "Angelo Naselli" <anaselli at linux.it> wrote:
> > >> I will test your patch tomorrow morning using digiKam like host
> > >
> > > right three tell us ok. So why not to commit them?
> >
> > I would feel better about it if Gilles approves them :-)
> >
> > > A question though does this commit break something in host
> > > applications?
> >
> > The only point where it could break is that I changed the signature of a
> > protected slot from load() to load(KFileTreeViewItem*). This would cause
> > errors in plugins if they inherited from UploadWidget and try to call
> > load() from the inherited class.
> > If that is a problem I can probably implement a fully binary safe
> > version.
>
> Is your patch solve this bko file :
>
> http://bugs.kde.org/show_bug.cgi?id=131429

No, I don't think so. This bug is really strange, I can't reproduce it.

I just tried running the batch process plugin from both Digikam and 
KPhotoAlbum. They do not seem to suffer from the same problem as Gwenview 
because they do not define uploadRoot as '/' and do not implement
'isDirectory()' to return true.
So these patches only fix the way Gwenview (and maybe ShowImg) use the upload 
widget.

Aurélien