[Kde-imaging] kipi-plugins : Current SVN compilation under KDE 3.3

[Angelo Naselli]

Alle 14:30, mercoledì 18 ottobre 2006, Colin Guthrie ha scritto:
> Hi,
> 
> Loïc Brarda wrote:
> > Hi,
> > 
> > I'm trying to compile the current SVN kipi-plugins under a variant of
> > RedHat Enterprise Linux 4, which uses KDE 3.3.1.
> > 
> 
> > ===================================================================
> > --- gallerylist.cpp     (revision 596722)
> > +++ gallerylist.cpp     (working copy)
> > @@ -59,9 +59,15 @@
> >    if (!blnShowOpen)
> >      showButtonOK(false);
> > 
> > +#if KDE_VERSION >= KDE_MAKE_VERSION(3,4,0)
> >    setButtonGuiItem(User3, KStdGuiItem::add());
> >    setButtonGuiItem(User2, KStdGuiItem::configure());
> >    setButtonGuiItem(User1, KStdGuiItem::remove());
> > +#else
> > +  setButtonGuiItem(User3, KGuiItem( i18n("Add"), "edit_add"));
> > +  setButtonGuiItem(User2, KGuiItem( i18n( "Confi&gure..." ), "configure" ));
> > +  setButtonGuiItem(User1, KGuiItem( i18n("Remove"), "edit_remove"));
> > +#endif
> >    setButtonGuiItem(Close, KStdGuiItem::close());
> >    setButtonGuiItem(Ok,    KStdGuiItem::open());
> 
> I'm not really happy about using the ifdef's to be honest... it'll just
> make the code more complicated in the long run.
Well looking at the code, that makes me think one more time
that using designer should avoid those problems :/
What happens with qt4 and further kde versions?
The #if/#ifdef become important i believe. And maybe some calls
won't be available anymore.
 
> Angelo, what should we do here? Should I just remove the 3.4+ code and
> revert back to the older versions?
Hard to decide :/ 
To have a quick solution i believe it's better the #if clause, but (even if i know
Gilles will hate me ;) ) i'd prefer using ui files where it's possible.

Angelo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 191 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-imaging/attachments/20061018/d8d2ffec/attachment-0001.pgp