[Kde-imaging] kipi-plugins : Current SVN compilation under KDE 3.3

[Colin Guthrie]

Hi,

Loïc Brarda wrote:
> Hi,
> 
> I'm trying to compile the current SVN kipi-plugins under a variant of
> RedHat Enterprise Linux 4, which uses KDE 3.3.1.
> 

> ===================================================================
> --- gallerylist.cpp     (revision 596722)
> +++ gallerylist.cpp     (working copy)
> @@ -59,9 +59,15 @@
>    if (!blnShowOpen)
>      showButtonOK(false);
> 
> +#if KDE_VERSION >= KDE_MAKE_VERSION(3,4,0)
>    setButtonGuiItem(User3, KStdGuiItem::add());
>    setButtonGuiItem(User2, KStdGuiItem::configure());
>    setButtonGuiItem(User1, KStdGuiItem::remove());
> +#else
> +  setButtonGuiItem(User3, KGuiItem( i18n("Add"), "edit_add"));
> +  setButtonGuiItem(User2, KGuiItem( i18n( "Confi&gure..." ), "configure" ));
> +  setButtonGuiItem(User1, KGuiItem( i18n("Remove"), "edit_remove"));
> +#endif
>    setButtonGuiItem(Close, KStdGuiItem::close());
>    setButtonGuiItem(Ok,    KStdGuiItem::open());

I'm not really happy about using the ifdef's to be honest... it'll just
make the code more complicated in the long run.

Angelo, what should we do here? Should I just remove the 3.4+ code and
revert back to the older versions?

Col.