[Kde-imaging] extragear/libs/kipi-plugins/sendimages

Valerio Fuoglio valerio.fuoglio at kdemail.net
Thu Nov 16 17:37:41 CET 2006


SVN commit 605396 by vfuoglio:

Fixed memory leaks (KHelpMenu unallocate about data)

CCMAIL: kde-imaging at kde.org

 M  +10 -8     sendimagesdialog.cpp  
 M  +2 -0      sendimagesdialog.h  


--- trunk/extragear/libs/kipi-plugins/sendimages/sendimagesdialog.cpp #605395:605396
@@ -153,17 +153,17 @@
 
     // About data and help button.
 
-    KIPIPlugins::KPAboutData * about = new KIPIPlugins::KPAboutData(I18N_NOOP("Send Images"),
-                                            NULL,
-                                            KAboutData::License_GPL,
-                                            I18N_NOOP("A Kipi plugin for emailing images"),
-                                            "(c) 2003-2005, Gilles Caulier");
+    m_about = new KIPIPlugins::KPAboutData(I18N_NOOP("Send Images"),
+                                           NULL,
+                                           KAboutData::License_GPL,
+                                           I18N_NOOP("A Kipi plugin for emailing images"),
+                                           "(c) 2003-2005, Gilles Caulier");
 
-    about->addAuthor("Gilles Caulier", I18N_NOOP("Author and maintainer"),
-                     "caulier dot gilles at free.fr");
+    m_about->addAuthor("Gilles Caulier", I18N_NOOP("Author and maintainer"),
+                       "caulier dot gilles at free.fr");
 
     m_helpButton = actionButton( Help );
-    KHelpMenu* helpMenu = new KHelpMenu(this, about, false);
+    KHelpMenu* helpMenu = new KHelpMenu(this, m_about, false);
     helpMenu->menu()->removeItemAt(0);
     helpMenu->menu()->insertItem(i18n("Send Image Handbook"), this, SLOT(slotHelp()), 0, -1, 0);
     m_helpButton->setPopup( helpMenu->menu() );
@@ -174,6 +174,8 @@
 SendImagesDialog::~SendImagesDialog()
 {
     if ( m_thumbJob ) delete m_thumbJob;
+
+    delete m_about;
 }
 
 void SendImagesDialog::readSettings(void)
--- trunk/extragear/libs/kipi-plugins/sendimages/sendimagesdialog.h #605395:605396
@@ -39,6 +39,7 @@
 #include <libkipi/interface.h>
 #include <libkipi/imagecollection.h>
 #include <libkipi/imageinfo.h>
+#include "kpaboutdata.h"
 
 class QComboBox;
 class QGroupBox;
@@ -153,6 +154,7 @@
    KSqueezedTextLabel *m_ImageAlbum;
    
    KIPI::Interface    *m_interface;
+   KIPIPlugins::KPAboutData *m_about;
    KIO::PreviewJob    *m_thumbJob;
 
  private:


More information about the Kde-imaging mailing list