[Kde-imaging] extragear/libs/kipi-plugins/rawconverter

[Valerio Fuoglio]

SVN commit 605395 by vfuoglio:

Fixed memory leaks (KHelpMenu unallocate about data)

CCMAIL: kde-imaging at kde.org

 M  +16 -15    batchdialog.cpp  
 M  +7 -1      batchdialog.h  


--- trunk/extragear/libs/kipi-plugins/rawconverter/batchdialog.cpp #605394:605395
@@ -138,28 +138,28 @@
 
     mainLayout->setColStretch(0, 10);
     mainLayout->setRowStretch(5, 10);
-    
+
     // ---------------------------------------------------------------
     // About data and help button.
 
     QPushButton *helpButton = actionButton( Help );
 
-    KIPIPlugins::KPAboutData * about = new KIPIPlugins::KPAboutData(I18N_NOOP("Raw Images Batch Converter"),
-                                        NULL,
-                                        KAboutData::License_GPL,
-                                        I18N_NOOP("A Kipi plugin for Raw images conversion\n"
-                                                  "This plugin uses the Dave Coffin Raw photo "
-                                                  "decoder program \"dcraw\""),
-                                        "(c) 2003-2005, Renchi Raju\n"
-                                        "(c) 2006, Gilles Caulier");
-    
-    about->addAuthor("Renchi Raju", I18N_NOOP("Original author"),
-                     "renchi at pooh.tam.uiuc.edu");
+    m_about = new KIPIPlugins::KPAboutData(I18N_NOOP("Raw Images Batch Converter"),
+                                           NULL,
+                                           KAboutData::License_GPL,
+                                           I18N_NOOP("A Kipi plugin for Raw images conversion\n"
+                                                     "This plugin uses the Dave Coffin Raw photo "
+                                                     "decoder program \"dcraw\""),
+                                           "(c) 2003-2005, Renchi Raju\n"
+                                           "(c) 2006, Gilles Caulier");
 
-    about->addAuthor("Gilles Caulier", I18N_NOOP("Maintainer"),
-                     "caulier dot gilles at kdemail dot net");
+    m_about->addAuthor("Renchi Raju", I18N_NOOP("Original author"),
+                       "renchi at pooh.tam.uiuc.edu");
 
-    KHelpMenu* helpMenu = new KHelpMenu(this, about, false);
+    m_about->addAuthor("Gilles Caulier", I18N_NOOP("Maintainer"),
+                       "caulier dot gilles at kdemail dot net");
+
+    KHelpMenu* helpMenu = new KHelpMenu(this, m_about, false);
     helpMenu->menu()->removeItemAt(0);
     helpMenu->menu()->insertItem(i18n("Raw Converter Handbook"),
                                  this, SLOT(slotHelp()), 0, -1, 0);
@@ -191,6 +191,7 @@
 
 BatchDialog::~BatchDialog()
 {
+    delete m_about;
     delete m_thread;
 }
 
--- trunk/extragear/libs/kipi-plugins/rawconverter/batchdialog.h #605394:605395
@@ -32,6 +32,10 @@
 
 #include <kdialogbase.h>
 
+// Local includes
+
+#include "kpaboutdata.h"
+
 class QTimer;
 class QWidget;
 class QCustomEvent;
@@ -106,12 +110,14 @@
     KListView           *m_listView;
 
     RawItem             *m_currentConvertItem;
-   
+
     ActionThread        *m_thread;
 
     DcrawSettingsWidget *m_decodingSettingsBox;
 
     SaveSettingsWidget  *m_saveSettingsBox;
+
+    KIPIPlugins::KPAboutData *m_about;
 };
 
 } // NameSpace KIPIRawConverterPlugin