[Kde-imaging] extragear/libs/kipi-plugins/rawconverter

[Valerio Fuoglio]

SVN commit 605397 by vfuoglio:

Fixed memory leaks (KHelpMenu unallocate about data)

CCMAIL: kde-imaging at kde.org

 M  +14 -13    singledialog.cpp  
 M  +6 -0      singledialog.h  


--- trunk/extragear/libs/kipi-plugins/rawconverter/singledialog.cpp #605396:605397
@@ -134,22 +134,22 @@
 
     QPushButton *helpButton = actionButton( Help );
 
-    KIPIPlugins::KPAboutData * about = new KIPIPlugins::KPAboutData(I18N_NOOP("Raw Image Converter"),
-                                            NULL,
-                                            KAboutData::License_GPL,
-                                            I18N_NOOP("A Kipi plugin for Raw image conversion\n"
-                                                      "This plugin uses the Dave Coffin Raw photo "
-                                                      "decoder program \"dcraw\""),
-                                            "(c) 2003-2005, Renchi Raju\n"
-                                            "(c) 2006, Gilles Caulier");
+    m_about = new KIPIPlugins::KPAboutData(I18N_NOOP("Raw Image Converter"),
+                                           NULL,
+                                           KAboutData::License_GPL,
+                                           I18N_NOOP("A Kipi plugin for Raw image conversion\n"
+                                                     "This plugin uses the Dave Coffin Raw photo "
+                                                     "decoder program \"dcraw\""),
+                                           "(c) 2003-2005, Renchi Raju\n"
+                                           "(c) 2006, Gilles Caulier");
 
-    about->addAuthor("Renchi Raju", I18N_NOOP("Original author"),
-                     "renchi at pooh.tam.uiuc.edu");
+    m_about->addAuthor("Renchi Raju", I18N_NOOP("Original author"),
+                       "renchi at pooh.tam.uiuc.edu");
 
-    about->addAuthor("Gilles Caulier", I18N_NOOP("Maintainer"),
-                     "caulier dot gilles at kdemail dot net");
+    m_about->addAuthor("Gilles Caulier", I18N_NOOP("Maintainer"),
+                       "caulier dot gilles at kdemail dot net");
 
-    KHelpMenu* helpMenu = new KHelpMenu(this, about, false);
+    KHelpMenu* helpMenu = new KHelpMenu(this, m_about, false);
     helpMenu->menu()->removeItemAt(0);
     helpMenu->menu()->insertItem(i18n("RAW Converter Handbook"), this, SLOT(slotHelp()), 0, -1, 0);
     helpButton->setPopup( helpMenu->menu() );
@@ -188,6 +188,7 @@
 
 SingleDialog::~SingleDialog()
 {
+    delete m_about;
     delete m_thread;
 }
 
--- trunk/extragear/libs/kipi-plugins/rawconverter/singledialog.h #605396:605397
@@ -31,6 +31,10 @@
 
 #include <kdialogbase.h>
 
+// Local includes
+
+#include "kpaboutdata.h"
+
 class QCloseEvent;
 class QCustomEvent;
 class QTimer;
@@ -106,6 +110,8 @@
     DcrawSettingsWidget *m_decodingSettingsBox;
 
     SaveSettingsWidget  *m_saveSettingsBox;
+
+    KIPIPlugins::KPAboutData *m_about; 
 };
 
 } // NameSpace KIPIRawConverterPlugin