[Kde-imaging] Problem Building from SVN

[Renchi Raju]

On Wed, 8 Jun 2005, Angelo Naselli wrote:

>>> something like that before using it?
>>> #ifndef __KDE_HAVE_GCC_VISIBILITY
>>> #undef KDE_EXPORT
>>> #define KDE_EXPORT
>>> #endif
>>
>> that still will not work. for a recently released extragear app, the admin
>> directory is fairly recent. and so __KDE_HAVE_GCC_VISIBILITY will be
>> defined, so it will never hit that part.
> Sorry, I don't understand I thougt if you dowwloaded svn you had also last
> admin directory.

if you get a recently released extragear app, it 
has a fairly recent admin directory. __KDE_HAVE_GCC_VISIBILITY, as you 
mentioned, is defined in admin/acinclude.m4.in . But that doesn't 
guarantee that KDE_EXPORT (in kdemacros.h) is defined.

For eg, a user with kde 3.2 downloads kipi from svn. he will get a very 
recent admin with __KDE_HAVE_GCC_VISIBILITY defined (if his compiler is 
recent enough). he doesn't have kdemacros.h because it was added only in 
kde 3.3.2. So for him KDE_EXPORT is undefined and it will break 
compilation.

> Can you give me the command to align to svn so I can try it to all my
> mandr[ake|iva] versions?

not sure what you meant here

> Mandrake 10.1 has no visibility support and gwenview svn version haven't
> __KDE_HAVE_GCC_VISIBILITY set.

thats because the compiler in mandrake 10.1 is not recent enough to 
support gcc visibility. but with a recent enough compiler, gwenview svn 
version will set that flag.

> Mandriva 10.2 has kde 3.3.2 with visibility support (Laurent Montel patched
> kde to be something like 3.3.X with X almost 90). So if you test it using kde
> version you can fail for some distros.

imo this backport was incorrect. packager should not modify kde version, 
as it makes life difficult for us who want to support multiple distros 
with different kde versions. right now, its either work with mandriva and 
break other distros or vice-versa.

renchi