[Kde-hardware-devel] Review Request 125182: Fix the brightness key being ignored during the animation

Xuetian Weng wengxt at gmail.com
Sat Sep 12 01:45:20 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125182/
-----------------------------------------------------------

Review request for Solid and Kai Uwe Broulik.


Repository: powerdevil


Description
-------

There is a check that update the m_cachedBrightness, which is not valid during the animation. Ignore if the brightness animation is running and calculate the new brightness level.

P.S. Why is this check there anyway? Is it useful or it's designed to workaround some hardware issue?


Diffs
-----

  daemon/backends/upower/powerdevilupowerbackend.cpp ff21f4e 

Diff: https://git.reviewboard.kde.org/r/125182/diff/


Testing
-------

Brightness can increase/decrease for every brightness key press.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150912/26d6f583/attachment.html>


More information about the Kde-hardware-devel mailing list