[Kde-hardware-devel] Review Request 125156: Fix brightness and animation

[Xuetian Weng]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125156/
-----------------------------------------------------------

(Updated Sept. 12, 2015, 1:29 a.m.)


Status
------

This change has been marked as submitted.


Review request for Solid and Kai Uwe Broulik.


Changes
-------

Submitted with commit 1005dd9a25c5fafea1f781c6d2a49fe99e219a34 by Weng Xuetian to branch Plasma/5.4.


Bugs: 346456 and 350676
    https://bugs.kde.org/show_bug.cgi?id=346456
    https://bugs.kde.org/show_bug.cgi?id=350676


Repository: powerdevil


Description
-------

As described in https://bugs.kde.org/show_bug.cgi?id=350676#c5

There are two issue here:
1. m_cacheBrightness may not be updated after animation.
2. setStartValue and setEndValue may emit unwanted valueChanged even when animation is stopped. Though I don't agree that the bug is in Qt (see my https://bugs.kde.org/show_bug.cgi?id=350676#c7). But we need to skip this emit anyway.

1 is resolved by always query the brightness when animation emit finished(). slotScreenBrightnessChanged is reused for this purpose.
2 is resolved by disconnect and reconnect the signal to skip setStartValue and setEndValue.


Diffs
-----

  daemon/backends/upower/powerdevilupowerbackend.cpp 3262c35 

Diff: https://git.reviewboard.kde.org/r/125156/diff/


Testing
-------

not be able to reproduce 350676.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150912/ba53c7c0/attachment-0001.html>