[Kde-hardware-devel] Review Request 125182: Fix the brightness key being ignored during the animation

[Igor Poboiko]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125182/#review85452
-----------------------------------------------------------


(from bug 350676)
> The reason that I don't want to update the cachedBrightness is, other usage of it shows that it always keeps real hardware brightness value with in it is used to whether to send brightness changed signal or not. From existing code, it seems that the code tries to avoid querying hardware value frequently and send a lot of brightness changed during animation.

Agreed.
What I want to say is following: even if cache fails and by some reason hardware didn't notify backend about changed brightness (AFAICS that's the only use-case for that check, except bugs like this) and we only found out it when key was pressed, we shouldn't ignore that keypress. It is definitely a bad user experience; I believe there is no need in that check at all.

- Igor Poboiko


On Сен. 12, 2015, 1:45 д.п., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125182/
> -----------------------------------------------------------
> 
> (Updated Сен. 12, 2015, 1:45 д.п.)
> 
> 
> Review request for Solid and Kai Uwe Broulik.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> There is a check that update the m_cachedBrightness, which is not valid during the animation. Ignore if the brightness animation is running and calculate the new brightness level.
> 
> P.S. Why is this check there anyway? Is it useful or it's designed to workaround some hardware issue?
> 
> 
> Diffs
> -----
> 
>   daemon/backends/upower/powerdevilupowerbackend.cpp ff21f4e 
> 
> Diff: https://git.reviewboard.kde.org/r/125182/diff/
> 
> 
> Testing
> -------
> 
> Brightness can increase/decrease for every brightness key press.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150915/0b7007f9/attachment.html>