[Kde-hardware-devel] Review Request 121995: Animate screen brightness change

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121995/#review73814
-----------------------------------------------------------



daemon/backends/upower/powerdevilupowerbackend.cpp
<https://git.reviewboard.kde.org/r/121995/#comment51344>

    Does the brightness animation really make sense when falling back to a brightness setter helper is needed? action.execute() will block.
    
    What if you check in PowerDevilUPowerBackend::setBrightnessValue if brightness control is supported, if not to the helper stuff there otherwise start the animation which calls this method which does only m_brightnessControl->setBrightnessValue(value)?


- Emmanuel Pescosta


On Jan. 11, 2015, 6 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121995/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2015, 6 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> Use a QPropertyAnimation to animate screen brightness changes, if supported by your configuration (enough steps available).
> 
> 
> Diffs
> -----
> 
>   daemon/backends/upower/powerdevilupowerbackend.h f4e7739 
>   daemon/backends/upower/powerdevilupowerbackend.cpp d7989bb 
> 
> Diff: https://git.reviewboard.kde.org/r/121995/diff/
> 
> 
> Testing
> -------
> 
> Using Kernel 3.18 it now reports ~900 steps for my display and so when idle the screen dims smoothly, when changing brightness or using the brightness keys, the screen brightness changes smoothly with the OSD reporting the proper value and battery monitor sliders adjusting slightly delayed. Didn't test using the helper rather than XRandr.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150112/1aff46fa/attachment.html>