[Kde-hardware-devel] Review Request 121995: Animate screen brightness change

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121995/#review73778
-----------------------------------------------------------

Ship it!


Besides unhardcode some values the rest looks good.

- Àlex Fiestas


On gen. 11, 2015, 5 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121995/
> -----------------------------------------------------------
> 
> (Updated gen. 11, 2015, 5 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> Use a QPropertyAnimation to animate screen brightness changes, if supported by your configuration (enough steps available).
> 
> 
> Diffs
> -----
> 
>   daemon/backends/upower/powerdevilupowerbackend.h f4e7739 
>   daemon/backends/upower/powerdevilupowerbackend.cpp d7989bb 
> 
> Diff: https://git.reviewboard.kde.org/r/121995/diff/
> 
> 
> Testing
> -------
> 
> Using Kernel 3.18 it now reports ~900 steps for my display and so when idle the screen dims smoothly, when changing brightness or using the brightness keys, the screen brightness changes smoothly with the OSD reporting the proper value and battery monitor sliders adjusting slightly delayed. Didn't test using the helper rather than XRandr.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150111/40cff42b/attachment.html>