[Kde-hardware-devel] Review Request 121677: Fix mobile connection wizard manual apn setting

[Xuetian Weng]

> On Dec. 26, 2014, 10:46 a.m., Lamarque Souza wrote:
> >

Hi, can you take a look at it again? I don't see there's any problem with this patch. See reply at each issue.


- Xuetian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121677/#review72521
-----------------------------------------------------------


On Dec. 26, 2014, 7:46 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121677/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2014, 7:46 a.m.)
> 
> 
> Review request for Solid and Lukáš Tinkl.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> Current problems:
> 1. if user selects manual provider, apn text is not editable.
> 2. if user select "not listed" in apn page, and go back to provider page and go next again, apn text will be editable while it shouldn't.
> 3. a redundant separator if there's on "My plan is not listed...".
> 
> This change reuses slotEnablePlanEditBox function to set mApnText to correct state, and remove a separator if it's manually set provider.
> 
> 
> Diffs
> -----
> 
>   libs/editor/widgets/mobileconnectionwizard.cpp 29ce4f7 
> 
> Diff: https://git.reviewboard.kde.org/r/121677/diff/
> 
> 
> Testing
> -------
> 
> problems above are fixed.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150112/0e4a07ab/attachment-0001.html>