[Kde-hardware-devel] Review Request 108912: Port libbluedevil to Bluez 5

[Àlex Fiestas]

> On March 6, 2013, 10:28 p.m., Àlex Fiestas wrote:
> > WoW! this is a lot of work !
> > 
> > Sorry for the delay but reviewboard forgot to send me this review apparently :/
> > 
> > Will make review the next weekend. Do you have a KDE account? you are going to need one so we can work on this in libbluedevil repo.
> > 
> > Thanks ! this really looks awesome.
> 
> Daniel Schaal wrote:
>     I only have a regular KDE Identity, but without committing rights. I also set up a repo on github, maybe we can work on it there?
> 
> Àlex Fiestas wrote:
>     I prefer doing it in kde so more community can see it, do you want me to ask the sysadmins to give you super powers?
> 
> Daniel Schaal wrote:
>     Who wouldn't want super powers :-) . It would be great, if you could do that.

Sysadmins tell me that you have a form in identity.kde.org, you can put me as "referer" if you are asked for one.


- Àlex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108912/#review28733
-----------------------------------------------------------


On March 8, 2013, 2:42 p.m., Daniel Schaal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108912/
> -----------------------------------------------------------
> 
> (Updated March 8, 2013, 2:42 p.m.)
> 
> 
> Review request for Bluedevil.
> 
> 
> Description
> -------
> 
> * Use DBus ObjectManager to get Adapter/Devices (inspired by solid's udisks2 backend)
> * remove cached properties, directly use DBus properties
> * add unpairedDeviceFound signal to Adapter
> * move [un]registerAgent to Manager
> * Update DBus interfaces for Bluez 5
> * Remove default adapter methods.
> 
> git repo available on https://github.com/schaal/libbluedevil
> 
> References:
> 
> http://www.bluez.org/bluez-5-api-introduction-and-porting-guide/
> https://git.kernel.org/cgit/bluetooth/bluez.git/tree/doc
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 5fb5039 
>   bluedevil/CMakeLists.txt 766d603 
>   bluedevil/bluedevil.h 798068b 
>   bluedevil/bluedeviladapter.h 65e5a4b 
>   bluedevil/bluedeviladapter.cpp 740ccb7 
>   bluedevil/bluedevildbustypes.h PRE-CREATION 
>   bluedevil/bluedevildevice.h c04131f 
>   bluedevil/bluedevildevice.cpp 2cefe01 
>   bluedevil/bluedevilmanager.h 0386b8e 
>   bluedevil/bluedevilmanager.cpp ff96906 
>   bluedevil/bluez/bluez-adapter.xml 5535fff 
>   bluedevil/bluez/bluez-device.xml 74ac081 
>   bluedevil/bluez/bluez-manager.xml fe7fcbe 
>   bluedevil/bluez/doc/adapter-api.txt 6098c76 
>   bluedevil/bluez/doc/agent-api.txt d8d35c0 
>   bluedevil/bluez/doc/audio-api.txt e7991f3 
>   bluedevil/bluez/doc/bluez-docs.xml 74a8bd1 
>   bluedevil/bluez/doc/control-api.txt 1a42846 
>   bluedevil/bluez/doc/device-api.txt b818299 
>   bluedevil/bluez/doc/gtk-doc.make 354ffb7 
>   bluedevil/bluez/doc/hfp-api.txt 93251e8 
>   bluedevil/bluez/doc/input-api.txt 7c3a4b2 
>   bluedevil/bluez/doc/manager-api.txt d2c1caf 
>   bluedevil/bluez/doc/network-api.txt eca60d4 
>   bluedevil/bluez/doc/node-api.txt 3ae4dee 
>   bluedevil/bluez/doc/serial-api.txt 5f9bd5f 
>   bluedevil/bluez/doc/service-api.txt 5c8c7f3 
>   bluedevil/bluez/doc/version.xml.in d78bda9 
>   bluedevil/bluez/org.bluez.Adapter1.xml PRE-CREATION 
>   bluedevil/bluez/org.bluez.AgentManager1.xml PRE-CREATION 
>   bluedevil/bluez/org.bluez.Device1.xml PRE-CREATION 
>   bluedevil/bluez/org.freedesktop.DBus.ObjectManager.xml PRE-CREATION 
>   bluedevil/bluez/org.freedesktop.DBus.Properties.xml PRE-CREATION 
>   bluedevil/test/adaptertest.h 0521fe1 
>   bluedevil/test/adaptertest.cpp fd1ab81 
>   bluedevil/test/bluedeviltest.cpp 2d3d0e2 
> 
> Diff: http://git.reviewboard.kde.org/r/108912/diff/
> 
> 
> Testing
> -------
> 
> adaptertest:
>  * added/removed a (virtual) adapter
>  * started/stopped bluetoothd
> 
> bluedeviltest:
>  * scanning for a device and removing a device
> 
> pairing wizard from bluedevil:
>  * pairing a headset device
> 
> 
> Thanks,
> 
> Daniel Schaal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130310/8f65d57b/attachment-0001.html>