[Kde-hardware-devel] Review Request 109352: Add hybrid suspend method to kde-workspace

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109352/#review28886
-----------------------------------------------------------


Code seems fine.

- Àlex Fiestas


On March 8, 2013, 1:24 p.m., Lukáš Tinkl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109352/
> -----------------------------------------------------------
> 
> (Updated March 8, 2013, 1:24 p.m.)
> 
> 
> Review request for Solid, Àlex Fiestas and Dario Freddi.
> 
> 
> Description
> -------
> 
> This patch adds the implementation of hybrid suspend method, complementing https://git.reviewboard.kde.org/r/109351/.
> 
> The hybrid suspend approach has the advantages of regular suspend (faster resuming than with hibernation) while being safer at the same time in case the battery runs out. More info: http://en.wikipedia.org/wiki/Sleep_mode#Hybrid_sleep
> 
> Affected components: shutdown dialog (ksmserver), kickoff, battery monitor, lock_logout applet, powermanagement data engine, powerdevil & its runner
> 
> Hybrid suspend becomes the preferred method to put the system into sleep thus greatly simplifying the user interface; if it's not available (because of system or kernel limitation), the current two options (suspend + hibernate) will be presented to the user. 
> 
> Technically, powerdevil has supported this approach since the beginning and both HAL and upower/systemd backends already implement it.
> 
> 
> This addresses bug 302968.
>     http://bugs.kde.org/show_bug.cgi?id=302968
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.h 7cafe71 
>   plasma/desktop/applets/kickoff/core/leavemodel.cpp 47559ce 
>   plasma/desktop/applets/kickoff/core/itemhandlers.cpp 4e83c37 
>   ksmserver/themes/default/main.qml 8924fac 
>   plasma/desktop/applets/kickoff/core/itemhandlers.h ec72cbe 
>   ksmserver/shutdowndlg.cpp ff0d488 
>   plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp 28fba18 
>   plasma/generic/applets/batterymonitor/contents/code/logic.js 974694a 
>   plasma/generic/applets/batterymonitor/contents/code/platform.js 59af3af 
>   plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml 76fb1ce 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml fedce02 
>   plasma/generic/applets/batterymonitor/platformcontents/touch/code/platform.js aa57ab8 
>   plasma/generic/applets/lock_logout/contents/config/main.xml 59475e2 
>   plasma/generic/applets/lock_logout/contents/ui/config.ui 07579b4 
>   plasma/generic/applets/lock_logout/contents/ui/data.js 9608a21 
>   plasma/generic/applets/lock_logout/contents/ui/lockout.qml efe49f6 
>   plasma/generic/dataengines/powermanagement/powermanagementengine.cpp 33a6e03 
>   plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 74eb36d 
>   powerdevil/daemon/actions/bundled/handlebuttoneventsconfig.cpp 0f3daf7 
>   powerdevil/daemon/actions/bundled/suspendsessionconfig.cpp 6097258 
>   powerdevil/daemon/powerdevilbackendinterface.h 91519a9 
>   powerdevil/daemon/powerdevilcore.h 77c3f2f 
>   powerdevil/daemon/powerdevilcore.cpp 2dcdbc6 
>   powerdevil/daemon/powerdevilfdoconnector.h 3542196 
>   powerdevil/daemon/powerdevilfdoconnector.cpp 76b96c5 
>   powerdevil/kcmodule/global/GeneralPage.cpp 84edd47 
> 
> Diff: http://git.reviewboard.kde.org/r/109352/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lukáš Tinkl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130310/d31bef3a/attachment.html>