<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108912/">http://git.reviewboard.kde.org/r/108912/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 6th, 2013, 10:28 p.m. UTC, <b>Àlex Fiestas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">WoW! this is a lot of work !
Sorry for the delay but reviewboard forgot to send me this review apparently :/
Will make review the next weekend. Do you have a KDE account? you are going to need one so we can work on this in libbluedevil repo.
Thanks ! this really looks awesome.</pre>
</blockquote>
<p>On March 7th, 2013, 5:22 p.m. UTC, <b>Daniel Schaal</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I only have a regular KDE Identity, but without committing rights. I also set up a repo on github, maybe we can work on it there?</pre>
</blockquote>
<p>On March 7th, 2013, 11:03 p.m. UTC, <b>Àlex Fiestas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I prefer doing it in kde so more community can see it, do you want me to ask the sysadmins to give you super powers?</pre>
</blockquote>
<p>On March 8th, 2013, 1:53 p.m. UTC, <b>Daniel Schaal</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Who wouldn't want super powers :-) . It would be great, if you could do that.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sysadmins tell me that you have a form in identity.kde.org, you can put me as "referer" if you are asked for one.</pre>
<br />
<p>- Àlex</p>
<br />
<p>On March 8th, 2013, 2:42 p.m. UTC, Daniel Schaal wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Bluedevil.</div>
<div>By Daniel Schaal.</div>
<p style="color: grey;"><i>Updated March 8, 2013, 2:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Use DBus ObjectManager to get Adapter/Devices (inspired by solid's udisks2 backend)
* remove cached properties, directly use DBus properties
* add unpairedDeviceFound signal to Adapter
* move [un]registerAgent to Manager
* Update DBus interfaces for Bluez 5
* Remove default adapter methods.
git repo available on https://github.com/schaal/libbluedevil
References:
http://www.bluez.org/bluez-5-api-introduction-and-porting-guide/
https://git.kernel.org/cgit/bluetooth/bluez.git/tree/doc</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">adaptertest:
* added/removed a (virtual) adapter
* started/stopped bluetoothd
bluedeviltest:
* scanning for a device and removing a device
pairing wizard from bluedevil:
* pairing a headset device</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(5fb5039)</span></li>
<li>bluedevil/CMakeLists.txt <span style="color: grey">(766d603)</span></li>
<li>bluedevil/bluedevil.h <span style="color: grey">(798068b)</span></li>
<li>bluedevil/bluedeviladapter.h <span style="color: grey">(65e5a4b)</span></li>
<li>bluedevil/bluedeviladapter.cpp <span style="color: grey">(740ccb7)</span></li>
<li>bluedevil/bluedevildbustypes.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>bluedevil/bluedevildevice.h <span style="color: grey">(c04131f)</span></li>
<li>bluedevil/bluedevildevice.cpp <span style="color: grey">(2cefe01)</span></li>
<li>bluedevil/bluedevilmanager.h <span style="color: grey">(0386b8e)</span></li>
<li>bluedevil/bluedevilmanager.cpp <span style="color: grey">(ff96906)</span></li>
<li>bluedevil/bluez/bluez-adapter.xml <span style="color: grey">(5535fff)</span></li>
<li>bluedevil/bluez/bluez-device.xml <span style="color: grey">(74ac081)</span></li>
<li>bluedevil/bluez/bluez-manager.xml <span style="color: grey">(fe7fcbe)</span></li>
<li>bluedevil/bluez/doc/adapter-api.txt <span style="color: grey">(6098c76)</span></li>
<li>bluedevil/bluez/doc/agent-api.txt <span style="color: grey">(d8d35c0)</span></li>
<li>bluedevil/bluez/doc/audio-api.txt <span style="color: grey">(e7991f3)</span></li>
<li>bluedevil/bluez/doc/bluez-docs.xml <span style="color: grey">(74a8bd1)</span></li>
<li>bluedevil/bluez/doc/control-api.txt <span style="color: grey">(1a42846)</span></li>
<li>bluedevil/bluez/doc/device-api.txt <span style="color: grey">(b818299)</span></li>
<li>bluedevil/bluez/doc/gtk-doc.make <span style="color: grey">(354ffb7)</span></li>
<li>bluedevil/bluez/doc/hfp-api.txt <span style="color: grey">(93251e8)</span></li>
<li>bluedevil/bluez/doc/input-api.txt <span style="color: grey">(7c3a4b2)</span></li>
<li>bluedevil/bluez/doc/manager-api.txt <span style="color: grey">(d2c1caf)</span></li>
<li>bluedevil/bluez/doc/network-api.txt <span style="color: grey">(eca60d4)</span></li>
<li>bluedevil/bluez/doc/node-api.txt <span style="color: grey">(3ae4dee)</span></li>
<li>bluedevil/bluez/doc/serial-api.txt <span style="color: grey">(5f9bd5f)</span></li>
<li>bluedevil/bluez/doc/service-api.txt <span style="color: grey">(5c8c7f3)</span></li>
<li>bluedevil/bluez/doc/version.xml.in <span style="color: grey">(d78bda9)</span></li>
<li>bluedevil/bluez/org.bluez.Adapter1.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>bluedevil/bluez/org.bluez.AgentManager1.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>bluedevil/bluez/org.bluez.Device1.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>bluedevil/bluez/org.freedesktop.DBus.ObjectManager.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>bluedevil/bluez/org.freedesktop.DBus.Properties.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>bluedevil/test/adaptertest.h <span style="color: grey">(0521fe1)</span></li>
<li>bluedevil/test/adaptertest.cpp <span style="color: grey">(fd1ab81)</span></li>
<li>bluedevil/test/bluedeviltest.cpp <span style="color: grey">(2d3d0e2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108912/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>