[Kde-hardware-devel] Review Request: Set dbus timeout for the unmount call to 10 mins

Jacopo De Simoi wilderkde at gmail.com
Mon May 23 22:01:11 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101428/
-----------------------------------------------------------

Review request for Solid and Lukáš Tinkl.


Summary
-------

Occasionally, when a long flush is taking place, the dbus call to unmount will timeout; the user receives a timeout message and 
does not know when it is safe to unplug the device anymore. This is due to a flaw in udisks api, which should not use replies but 
signals, and will be reported shortly upstream.
Meanwhile this is a reasonable workaround while we wait for new api


Diffs
-----

  solid/solid/backends/udisks/udisksstorageaccess.h 6bf729cce4e5c5ec79fa82dd56fcd825d9f79515 
  solid/solid/backends/udisks/udisksstorageaccess.cpp 4cb0f7ceeee2f7a342346fd7507df6788a7bf82c 

Diff: http://git.reviewboard.kde.org/r/101428/diff


Testing
-------


Thanks,

Jacopo De

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20110523/a3a10d16/attachment.htm 


More information about the Kde-hardware-devel mailing list