[Kde-hardware-devel] Review Request: Sort out ejecting of devices

[Jacopo De Simoi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101453/
-----------------------------------------------------------

Review request for Solid, Lukáš Tinkl and Ozan Çağlayan.


Summary
-------

Call DeviceEject only if the drive actually requires to be ejected, 
moreover call the special eject routine if the drive IS an optical Disc, not if it is NOT an optical disc…


This addresses bug 270490.
    http://bugs.kde.org/show_bug.cgi?id=270490


Diffs
-----

  solid/solid/backends/udisks/udisksstorageaccess.h 6bf729cce4e5c5ec79fa82dd56fcd825d9f79515 
  solid/solid/backends/udisks/udisksstorageaccess.cpp 4cb0f7ceeee2f7a342346fd7507df6788a7bf82c 

Diff: http://git.reviewboard.kde.org/r/101453/diff


Testing
-------


Thanks,

Jacopo De

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20110527/0d863e88/attachment.htm