[Kde-hardware-devel] Re: Review Request: Add two more methods to Battery: capacity and hasRecallNotice

[Dario Freddi]

> On 2010-11-10 12:14:02, Pino Toscano wrote:
> > /trunk/KDE/kdelibs/solid/solid/backends/hal/halbattery.cpp, lines 89-90
> > <http://svn.reviewboard.kde.org/r/5814/diff/3/?file=41071#file41071line89>
> >
> >     design should always be >= last_full, so that division between int will give either 0 or 1.

You are correct. Will QVariant::toDouble() suffice here, or do I need to use toInt() and subsequently cast to double?


> On 2010-11-10 12:14:02, Pino Toscano wrote:
> > /trunk/KDE/kdelibs/solid/solid/battery.h, line 46
> > <http://svn.reviewboard.kde.org/r/5814/diff/3/?file=41078#file41078line46>
> >
> >     Shouldn't the property name be better as "hasRecallNotice"? Otherwise it seems like it is an actual value.

The property naming follows the current naming schema of other bool properties in Battery (isRechargeable->rechargeable, isPlugged->plugged). Probably Kevin can tell us some more? I agree with you the naming seems weird; though, DBus properties in upower follow the same naming schema, so I suppose it's a convention which applies to properties.


- Dario


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5814/#review8618
-----------------------------------------------------------


On 2010-11-10 12:03:14, Dario Freddi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5814/
> -----------------------------------------------------------
> 
> (Updated 2010-11-10 12:03:14)
> 
> 
> Review request for Solid and Kevin Ottens.
> 
> 
> Summary
> -------
> 
> This patch adds two new more methods to Battery, capacity and hasRecallNotice, and implementation for upower, HAL and IOKit.
> 
> 
> This addresses bug 218546.
>     https://bugs.kde.org/show_bug.cgi?id=218546
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/solid/solid/backends/fakehw/fakebattery.h 1195053 
>   /trunk/KDE/kdelibs/solid/solid/backends/fakehw/fakebattery.cpp 1195053 
>   /trunk/KDE/kdelibs/solid/solid/backends/hal/halbattery.h 1195053 
>   /trunk/KDE/kdelibs/solid/solid/backends/hal/halbattery.cpp 1195053 
>   /trunk/KDE/kdelibs/solid/solid/backends/iokit/iokitbattery.h 1195053 
>   /trunk/KDE/kdelibs/solid/solid/backends/iokit/iokitbattery.cpp 1195053 
>   /trunk/KDE/kdelibs/solid/solid/backends/upower/upowerbattery.h 1195053 
>   /trunk/KDE/kdelibs/solid/solid/backends/upower/upowerbattery.cpp 1195053 
>   /trunk/KDE/kdelibs/solid/solid/backends/wmi/wmibattery.h 1195053 
>   /trunk/KDE/kdelibs/solid/solid/backends/wmi/wmibattery.cpp 1195053 
>   /trunk/KDE/kdelibs/solid/solid/battery.h 1195053 
>   /trunk/KDE/kdelibs/solid/solid/battery.cpp 1195053 
>   /trunk/KDE/kdelibs/solid/solid/ifaces/battery.h 1195053 
> 
> Diff: http://svn.reviewboard.kde.org/r/5814/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dario
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20101110/0490d051/attachment-0001.htm