[Kde-hardware-devel] Re: Review Request: Add two more methods to Battery: capacity and hasRecallNotice

[Pino Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5814/#review8618
-----------------------------------------------------------



/trunk/KDE/kdelibs/solid/solid/backends/hal/halbattery.cpp
<http://svn.reviewboard.kde.org/r/5814/#comment9058>

    design should always be >= last_full, so that division between int will give either 0 or 1.



/trunk/KDE/kdelibs/solid/solid/battery.h
<http://svn.reviewboard.kde.org/r/5814/#comment9059>

    Shouldn't the property name be better as "hasRecallNotice"? Otherwise it seems like it is an actual value.


- Pino


On 2010-11-10 12:03:14, Dario Freddi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5814/
> -----------------------------------------------------------
> 
> (Updated 2010-11-10 12:03:14)
> 
> 
> Review request for Solid and Kevin Ottens.
> 
> 
> Summary
> -------
> 
> This patch adds two new more methods to Battery, capacity and hasRecallNotice, and implementation for upower, HAL and IOKit.
> 
> 
> This addresses bug 218546.
>     https://bugs.kde.org/show_bug.cgi?id=218546
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/solid/solid/backends/fakehw/fakebattery.h 1195053 
>   /trunk/KDE/kdelibs/solid/solid/backends/fakehw/fakebattery.cpp 1195053 
>   /trunk/KDE/kdelibs/solid/solid/backends/hal/halbattery.h 1195053 
>   /trunk/KDE/kdelibs/solid/solid/backends/hal/halbattery.cpp 1195053 
>   /trunk/KDE/kdelibs/solid/solid/backends/iokit/iokitbattery.h 1195053 
>   /trunk/KDE/kdelibs/solid/solid/backends/iokit/iokitbattery.cpp 1195053 
>   /trunk/KDE/kdelibs/solid/solid/backends/upower/upowerbattery.h 1195053 
>   /trunk/KDE/kdelibs/solid/solid/backends/upower/upowerbattery.cpp 1195053 
>   /trunk/KDE/kdelibs/solid/solid/backends/wmi/wmibattery.h 1195053 
>   /trunk/KDE/kdelibs/solid/solid/backends/wmi/wmibattery.cpp 1195053 
>   /trunk/KDE/kdelibs/solid/solid/battery.h 1195053 
>   /trunk/KDE/kdelibs/solid/solid/battery.cpp 1195053 
>   /trunk/KDE/kdelibs/solid/solid/ifaces/battery.h 1195053 
> 
> Diff: http://svn.reviewboard.kde.org/r/5814/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dario
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20101110/58169522/attachment.htm