<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5814/">http://svn.reviewboard.kde.org/r/5814/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 10th, 2010, 12:14 p.m., <b>Pino Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/5814/diff/3/?file=41071#file41071line89" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdelibs/solid/solid/backends/hal/halbattery.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">uint Solid::Backends::Hal::Battery::capacity() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">89</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">uint</span> <span class="n">capacity</span> <span class="o">=</span> <span class="p">(</span><span class="n">m_device</span><span class="o">-></span><span class="n">property</span><span class="p">(</span><span class="s">"battery.reporting.last_full"</span><span class="p">).</span><span class="n">toInt</span><span class="p">()</span> <span class="o">/</span><span class="ew"> </span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">90</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_device</span><span class="o">-></span><span class="n">property</span><span class="p">(</span><span class="s">"battery.reporting.design"</span><span class="p">).</span><span class="n">toInt</span><span class="p">())</span> <span class="o">*</span> <span class="mi">100</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">design should always be >= last_full, so that division between int will give either 0 or 1.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You are correct. Will QVariant::toDouble() suffice here, or do I need to use toInt() and subsequently cast to double?</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 10th, 2010, 12:14 p.m., <b>Pino Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/5814/diff/3/?file=41078#file41078line46" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdelibs/solid/solid/battery.h</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace Solid</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">46</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_PROPERTY</span><span class="p">(</span><span class="n">bool</span> <span class="n">recallNotice</span> <span class="n">READ</span> <span class="n">hasRecallNotice</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shouldn't the property name be better as "hasRecallNotice"? Otherwise it seems like it is an actual value.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The property naming follows the current naming schema of other bool properties in Battery (isRechargeable->rechargeable, isPlugged->plugged). Probably Kevin can tell us some more? I agree with you the naming seems weird; though, DBus properties in upower follow the same naming schema, so I suppose it's a convention which applies to properties.</pre>
<br />
<p>- Dario</p>
<br />
<p>On November 10th, 2010, 12:03 p.m., Dario Freddi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid and Kevin Ottens.</div>
<div>By Dario Freddi.</div>
<p style="color: grey;"><i>Updated 2010-11-10 12:03:14</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds two new more methods to Battery, capacity and hasRecallNotice, and implementation for upower, HAL and IOKit.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=218546">218546</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/solid/solid/backends/fakehw/fakebattery.h <span style="color: grey">(1195053)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/fakehw/fakebattery.cpp <span style="color: grey">(1195053)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/hal/halbattery.h <span style="color: grey">(1195053)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/hal/halbattery.cpp <span style="color: grey">(1195053)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/iokit/iokitbattery.h <span style="color: grey">(1195053)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/iokit/iokitbattery.cpp <span style="color: grey">(1195053)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/upower/upowerbattery.h <span style="color: grey">(1195053)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/upower/upowerbattery.cpp <span style="color: grey">(1195053)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/wmi/wmibattery.h <span style="color: grey">(1195053)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/wmi/wmibattery.cpp <span style="color: grey">(1195053)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/battery.h <span style="color: grey">(1195053)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/battery.cpp <span style="color: grey">(1195053)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/ifaces/battery.h <span style="color: grey">(1195053)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5814/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>