Review Request 129568: Change strings to address i18n issues

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129568/#review101427
-----------------------------------------------------------




src/Gui/SmartSpinBox.cpp (line 43)
<https://git.reviewboard.kde.org/r/129568/#comment67909>

    is there a reason this really needs to be a double?
    
    Is it critical to be able to take a screenshot in 2.4 seconds?
    
    If it is, this thing should probably look like
    
    if (val == (int)val) {
      // it's an integer
      setSuffix(i18np(" second", " seconds", int(val)));
    } else {
      // it's a decimal number
      setSuffix(i18n(" seconds")); 
    }


- Albert Astals Cid


On des. 6, 2016, 6:58 p.m., Peter Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129568/
> -----------------------------------------------------------
> 
> (Updated des. 6, 2016, 6:58 p.m.)
> 
> 
> Review request for KDE Graphics, Albert Astals Cid and Boudhayan Gupta.
> 
> 
> Repository: spectacle
> 
> 
> Description
> -------
> 
> Change strings to address i18n issues
> 
> Change "Preferences" to "Configure" (window title) and use a
> KStandardAction::preferences item (and get the "Configure Spectacle..."
> text for free).
> 
> Add TODO comment for inconsistent use of "screen" and "monitors", this
> requires more changes beyond changing text.
> 
> 
> Diffs
> -----
> 
>   doc/index.docbook 5ad5ef08d8834d4b8ac982ea5c1c928cdac5ecab 
>   src/Gui/ExportMenu.cpp 4b894c7d991140f08912a90eb41571108439264b 
>   src/Gui/KSMainWindow.cpp 5a4dd77564e98b961adcadcec18e5d5fad4d4bb4 
>   src/Gui/KSWidget.cpp 380bff6809131477446aaecb947c2d7b7dde3289 
>   src/Gui/SettingsDialog/SettingsDialog.cpp 7cfe8e2ca676a414d7a84a20b134b2e1ae89a9b3 
>   src/Gui/SmartSpinBox.cpp 4938f84f62b194fcbd2461915e628dfb45c4abb4 
> 
> Diff: https://git.reviewboard.kde.org/r/129568/diff/
> 
> 
> Testing
> -------
> 
> Checked text under Save menu (icon has also changed), Configure dialog.
> 
> 
> Thanks,
> 
> Peter Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20161213/a3eae9aa/attachment.html>