<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129568/">https://git.reviewboard.kde.org/r/129568/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/129568/diff/2/?file=487106#file487106line43" style="color: black; font-weight: bold; text-decoration: underline;">src/Gui/SmartSpinBox.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setSuffix</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span class="s">" second"</span><span class="p">));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">43</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setSuffix</span><span class="p">(</span><span class="n">i18np</span><span class="p">(</span><span class="s">" second"</span><span class="p">,</span> <span class="s">" seconds"</span><span class="p">,</span> <span class="kt">int</span><span class="p">(</span><span class="n">val</span><span class="p">)));</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">is there a reason this really needs to be a double?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is it critical to be able to take a screenshot in 2.4 seconds?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If it is, this thing should probably look like</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if (val == (int)val) {
// it's an integer
setSuffix(i18np(" second", " seconds", int(val)));
} else {
// it's a decimal number
setSuffix(i18n(" seconds"));
}</p></pre>
</div>
</div>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On desembre 6th, 2016, 6:58 p.m. UTC, Peter Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Graphics, Albert Astals Cid and Boudhayan Gupta.</div>
<div>By Peter Wu.</div>
<p style="color: grey;"><i>Updated des. 6, 2016, 6:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
spectacle
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Change strings to address i18n issues</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Change "Preferences" to "Configure" (window title) and use a
KStandardAction::preferences item (and get the "Configure Spectacle..."
text for free).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add TODO comment for inconsistent use of "screen" and "monitors", this
requires more changes beyond changing text.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Checked text under Save menu (icon has also changed), Configure dialog.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/index.docbook <span style="color: grey">(5ad5ef08d8834d4b8ac982ea5c1c928cdac5ecab)</span></li>
<li>src/Gui/ExportMenu.cpp <span style="color: grey">(4b894c7d991140f08912a90eb41571108439264b)</span></li>
<li>src/Gui/KSMainWindow.cpp <span style="color: grey">(5a4dd77564e98b961adcadcec18e5d5fad4d4bb4)</span></li>
<li>src/Gui/KSWidget.cpp <span style="color: grey">(380bff6809131477446aaecb947c2d7b7dde3289)</span></li>
<li>src/Gui/SettingsDialog/SettingsDialog.cpp <span style="color: grey">(7cfe8e2ca676a414d7a84a20b134b2e1ae89a9b3)</span></li>
<li>src/Gui/SmartSpinBox.cpp <span style="color: grey">(4938f84f62b194fcbd2461915e628dfb45c4abb4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129568/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>