Review Request 129568: Change strings to address i18n issues

Peter Wu peter at lekensteyn.nl
Tue Dec 6 18:53:10 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129568/
-----------------------------------------------------------

(Updated Dec. 6, 2016, 7:53 p.m.)


Review request for KDE Graphics and Boudhayan Gupta.


Repository: spectacle


Description (updated)
-------

Change strings to address i18n issues

Change "Preferences" to "Configure" (window title) and use a
KStandardAction::preferences item (and get the "Configure Spectacle..."
text for free).

Add TODO comment for inconsistent use of "screen" and "monitors", this
requires more changes beyond changing text.


Diffs (updated)
-----

  doc/index.docbook 5ad5ef08d8834d4b8ac982ea5c1c928cdac5ecab 
  src/Gui/ExportMenu.cpp 4b894c7d991140f08912a90eb41571108439264b 
  src/Gui/KSMainWindow.cpp 5a4dd77564e98b961adcadcec18e5d5fad4d4bb4 
  src/Gui/KSWidget.cpp 380bff6809131477446aaecb947c2d7b7dde3289 
  src/Gui/SettingsDialog/SettingsDialog.cpp 7cfe8e2ca676a414d7a84a20b134b2e1ae89a9b3 
  src/Gui/SmartSpinBox.cpp 4938f84f62b194fcbd2461915e628dfb45c4abb4 

Diff: https://git.reviewboard.kde.org/r/129568/diff/


Testing (updated)
-------

Checked text under Save menu (icon has also changed), Configure dialog.


Thanks,

Peter Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20161206/8ea57016/attachment.html>


More information about the Kde-graphics-devel mailing list