[Kde-graphics-devel] Review Request 125230: Initial RR for KF5/Qt5 port of kamera

[Jeremy Whiting]

> On Sept. 15, 2015, 4:06 a.m., Luca Beltrame wrote:
> > CMakeLists.txt, line 25
> > <https://git.reviewboard.kde.org/r/125230/diff/3/?file=403372#file403372line25>
> >
> >     I'm not knowledgeable enough in CMake, but do we have a FindGphoto2....) module somewhere?
> 
> Christian Butcher wrote:
>     Digikam packages a FindGphoto2.cmake file in it's cmake directory on the frameworks branch (on the KDE4 (master) branch, it uses macro_optional_find_package - I can't find how this works but I suppose it's fairly irrelevant in this case).
>     Presumably I could copy that file into kamera, if that's preferred? I don't know if the FindGphoto2.cmake file is installed by digikam - I didn't find it when I searched earlier today, although I could have been looking in the wrong place. However, I assume even if that were the case, it would be pretty awful to depend on an installation of digikam to make kamera work. Other (similar) findgphoto2.cmake files are available, under a variety of licenses, that I found using google.
>     
>     Why are they preferred to pkg-config? Standardisation?

cmake works like this. If the library has a FooConfig.cmake to find itself from other applications that use it. It prefers that. If it doesn't ship a FooConfig.cmake then every user of Foo needs to have their own FindFoo.cmake in their own sources. The FindFoo.cmake should not get installed as it is usually specific to the application (defines variables that the application itself uses, etc.)

So either copy the FindGPhoto2.cmake from digikam and use it (and modify it as needed for kamera) or use pkg-config or convince libgphoto2 to ship a GPhoto2Config.cmake itself. I imagine the first option would be the quickest and easiest, and if the latter happens sometime down the road we can remove FindGPhoto2.cmake.


- Jeremy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125230/#review85435
-----------------------------------------------------------


On Sept. 15, 2015, 4:14 a.m., Christian Butcher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125230/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 4:14 a.m.)
> 
> 
> Review request for KDE Graphics, Christoph Feck and Jeremy Whiting.
> 
> 
> Repository: kamera
> 
> 
> Description
> -------
> 
> Initial RR for port of kamera to KF5/Qt5
> 
> Adds 'camera:/' protocol to kio
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a201c0d9ea85e1c437fe991a1b1496622dffd930 
>   kcontrol/CMakeLists.txt 9e6603f3e121bf56bccebecb6927831ffb77848e 
>   kcontrol/kamera.cpp 3e6540a5a49112bd00693486a0b815e551c6f6eb 
>   kcontrol/kamera.desktop cb5c7845ba4b57bf3bb3a23e548ef00efcff7a97 
>   kcontrol/kamera.h a91149dba6828687fc84a0e0892c3d6874b49362 
>   kcontrol/kameraconfigdialog.h 4f0ee67f37165b8dd424694032001cdc6cf18b57 
>   kcontrol/kameraconfigdialog.cpp b0d601f83dfd0649da533d3bd29ffd46914c6403 
>   kcontrol/kameradevice.h 828eda4df28a24d169f179abf6c43a8afa640fe7 
>   kcontrol/kameradevice.cpp 38f17871838a8847eef864d0a7ba429929ef46af 
>   kioslave/CMakeLists.txt ddf8f2cd6840b50b27157e6d57dc96244afbd613 
>   kioslave/kamera.h b072fca34252228392868750a2714ff3812d3aeb 
>   kioslave/kamera.cpp 081e96f681da708d91f59241ac9273be8f46e4b7 
>   solid_camera.desktop ce419407c372ca1b39c699fec7e583591712b4b1 
> 
> Diff: https://git.reviewboard.kde.org/r/125230/diff/
> 
> 
> Testing
> -------
> 
> Can open camera using the 'camera:/' protocol in Dolphin.
> Can copy files from subdirectories of the camera to my $HOME directory.
> These files open properly.
> 
> Cannot open files in place on the camera, but suspect this due to a consolekit2 session management issue on my computer. ~/.xsession-errors describes the camera as busy for the 15 'tries' as handled by 'kioslace/kamera.cpp' in 'openKamera' function.
> 
> ~/.xsession-errors calls the destructor appropriately when disconnecting the camera.
> 
> 
> Thanks,
> 
> Christian Butcher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20150915/c21166f4/attachment.html>