[Kde-graphics-devel] Review Request 125230: Initial RR for KF5/Qt5 port of kamera

[Christian Butcher]

> On Sept. 15, 2015, 10:06 a.m., Luca Beltrame wrote:
> > kcontrol/kameradevice.cpp, line 474
> > <https://git.reviewboard.kde.org/r/125230/diff/3/?file=403380#file403380line474>
> >
> >     Is this part of the stuff that does not work or you need to figure out what it does?
> 
> Christian Butcher wrote:
>     The computer I'm using at the moment doesn't have the code but if I remember right this is a default button, and might be replaced by some lines giving shortcuts like CTRL-RETURN or similar. I don't think they're in quite the same place - this is at the end of a function iirc.

Fixed in new diff. Turns out the original code disabled the "Ok" button when adding a new camera until at least some of the settings were chosen - I have now replicated this behaviour


> On Sept. 15, 2015, 10:06 a.m., Luca Beltrame wrote:
> > kioslave/kamera.cpp, line 95
> > <https://git.reviewboard.kde.org/r/125230/diff/3/?file=403383#file403383line95>
> >
> >     You may want to set a proper componentData and also a translation domain: otherwise you will not be able to load translations.
> 
> Christian Butcher wrote:
>     Will look into how to do this and then implement it

Fixed translation domain, dropping componentData after IRC conversation regarding KAboutData absence


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125230/#review85435
-----------------------------------------------------------


On Sept. 15, 2015, 10:14 a.m., Christian Butcher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125230/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 10:14 a.m.)
> 
> 
> Review request for KDE Graphics, Christoph Feck and Jeremy Whiting.
> 
> 
> Repository: kamera
> 
> 
> Description
> -------
> 
> Initial RR for port of kamera to KF5/Qt5
> 
> Adds 'camera:/' protocol to kio
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a201c0d9ea85e1c437fe991a1b1496622dffd930 
>   kcontrol/CMakeLists.txt 9e6603f3e121bf56bccebecb6927831ffb77848e 
>   kcontrol/kamera.cpp 3e6540a5a49112bd00693486a0b815e551c6f6eb 
>   kcontrol/kamera.desktop cb5c7845ba4b57bf3bb3a23e548ef00efcff7a97 
>   kcontrol/kamera.h a91149dba6828687fc84a0e0892c3d6874b49362 
>   kcontrol/kameraconfigdialog.h 4f0ee67f37165b8dd424694032001cdc6cf18b57 
>   kcontrol/kameraconfigdialog.cpp b0d601f83dfd0649da533d3bd29ffd46914c6403 
>   kcontrol/kameradevice.h 828eda4df28a24d169f179abf6c43a8afa640fe7 
>   kcontrol/kameradevice.cpp 38f17871838a8847eef864d0a7ba429929ef46af 
>   kioslave/CMakeLists.txt ddf8f2cd6840b50b27157e6d57dc96244afbd613 
>   kioslave/kamera.h b072fca34252228392868750a2714ff3812d3aeb 
>   kioslave/kamera.cpp 081e96f681da708d91f59241ac9273be8f46e4b7 
>   solid_camera.desktop ce419407c372ca1b39c699fec7e583591712b4b1 
> 
> Diff: https://git.reviewboard.kde.org/r/125230/diff/
> 
> 
> Testing
> -------
> 
> Can open camera using the 'camera:/' protocol in Dolphin.
> Can copy files from subdirectories of the camera to my $HOME directory.
> These files open properly.
> 
> Cannot open files in place on the camera, but suspect this due to a consolekit2 session management issue on my computer. ~/.xsession-errors describes the camera as busy for the 15 'tries' as handled by 'kioslace/kamera.cpp' in 'openKamera' function.
> 
> ~/.xsession-errors calls the destructor appropriately when disconnecting the camera.
> 
> 
> Thanks,
> 
> Christian Butcher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20150917/b0e5f752/attachment.html>