<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125230/">https://git.reviewboard.kde.org/r/125230/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 15th, 2015, 4:06 a.m. MDT, <b>Luca Beltrame</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/125230/diff/3/?file=403372#file403372line25" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">19</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">pkg_check_modules</span><span class="p">(</span><span class="s">GPHOTO2</span> <span class="s">REQUIRED</span> <span class="s">libgphoto2</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not knowledgeable enough in CMake, but do we have a FindGphoto2....) module somewhere?</p></pre>
</blockquote>
<p>On September 15th, 2015, 8:57 a.m. MDT, <b>Christian Butcher</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Digikam packages a FindGphoto2.cmake file in it's cmake directory on the frameworks branch (on the KDE4 (master) branch, it uses macro_optional_find_package - I can't find how this works but I suppose it's fairly irrelevant in this case).
Presumably I could copy that file into kamera, if that's preferred? I don't know if the FindGphoto2.cmake file is installed by digikam - I didn't find it when I searched earlier today, although I could have been looking in the wrong place. However, I assume even if that were the case, it would be pretty awful to depend on an installation of digikam to make kamera work. Other (similar) findgphoto2.cmake files are available, under a variety of licenses, that I found using google.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why are they preferred to pkg-config? Standardisation?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">cmake works like this. If the library has a FooConfig.cmake to find itself from other applications that use it. It prefers that. If it doesn't ship a FooConfig.cmake then every user of Foo needs to have their own FindFoo.cmake in their own sources. The FindFoo.cmake should not get installed as it is usually specific to the application (defines variables that the application itself uses, etc.)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So either copy the FindGPhoto2.cmake from digikam and use it (and modify it as needed for kamera) or use pkg-config or convince libgphoto2 to ship a GPhoto2Config.cmake itself. I imagine the first option would be the quickest and easiest, and if the latter happens sometime down the road we can remove FindGPhoto2.cmake.</p></pre>
<br />
<p>- Jeremy</p>
<br />
<p>On September 15th, 2015, 4:14 a.m. MDT, Christian Butcher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Graphics, Christoph Feck and Jeremy Whiting.</div>
<div>By Christian Butcher.</div>
<p style="color: grey;"><i>Updated Sept. 15, 2015, 4:14 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kamera
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Initial RR for port of kamera to KF5/Qt5</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Adds 'camera:/' protocol to kio</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can open camera using the 'camera:/' protocol in Dolphin.
Can copy files from subdirectories of the camera to my $HOME directory.
These files open properly.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Cannot open files in place on the camera, but suspect this due to a consolekit2 session management issue on my computer. ~/.xsession-errors describes the camera as busy for the 15 'tries' as handled by 'kioslace/kamera.cpp' in 'openKamera' function.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">~/.xsession-errors calls the destructor appropriately when disconnecting the camera.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(a201c0d9ea85e1c437fe991a1b1496622dffd930)</span></li>
<li>kcontrol/CMakeLists.txt <span style="color: grey">(9e6603f3e121bf56bccebecb6927831ffb77848e)</span></li>
<li>kcontrol/kamera.cpp <span style="color: grey">(3e6540a5a49112bd00693486a0b815e551c6f6eb)</span></li>
<li>kcontrol/kamera.desktop <span style="color: grey">(cb5c7845ba4b57bf3bb3a23e548ef00efcff7a97)</span></li>
<li>kcontrol/kamera.h <span style="color: grey">(a91149dba6828687fc84a0e0892c3d6874b49362)</span></li>
<li>kcontrol/kameraconfigdialog.h <span style="color: grey">(4f0ee67f37165b8dd424694032001cdc6cf18b57)</span></li>
<li>kcontrol/kameraconfigdialog.cpp <span style="color: grey">(b0d601f83dfd0649da533d3bd29ffd46914c6403)</span></li>
<li>kcontrol/kameradevice.h <span style="color: grey">(828eda4df28a24d169f179abf6c43a8afa640fe7)</span></li>
<li>kcontrol/kameradevice.cpp <span style="color: grey">(38f17871838a8847eef864d0a7ba429929ef46af)</span></li>
<li>kioslave/CMakeLists.txt <span style="color: grey">(ddf8f2cd6840b50b27157e6d57dc96244afbd613)</span></li>
<li>kioslave/kamera.h <span style="color: grey">(b072fca34252228392868750a2714ff3812d3aeb)</span></li>
<li>kioslave/kamera.cpp <span style="color: grey">(081e96f681da708d91f59241ac9273be8f46e4b7)</span></li>
<li>solid_camera.desktop <span style="color: grey">(ce419407c372ca1b39c699fec7e583591712b4b1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125230/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>