[Kde-graphics-devel] Re: Review Request: Indication that there is no camera set up for Kamera's KCM (similar to Bluedevil)

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102102/#review5141
-----------------------------------------------------------



kcontrol/kamera.cpp
<http://git.reviewboard.kde.org/r/102102/#comment4637>

    You should handle the deletion of the widgets you create in this method (or reuse them), otherwise going back and forth between having no cameras and having a camera creates the widgets all the time increasing memory usage for no reason


- Albert


On July 27, 2011, 5:16 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102102/
> -----------------------------------------------------------
> 
> (Updated July 27, 2011, 5:16 p.m.)
> 
> 
> Review request for KDE Graphics.
> 
> 
> Summary
> -------
> 
> In Bluedevil you have a nice message indicating that no Bluetooth Device has yet been added. This patch implements the same behavior for Kamera's KCM.
> Screenshot: http://privat.broulik.de/kamerakcmpatch.png
> 
> 
> Diffs
> -----
> 
>   kcontrol/kamera.h abb766f 
>   kcontrol/kamera.cpp ad3cf2e 
> 
> Diff: http://git.reviewboard.kde.org/r/102102/diff
> 
> 
> Testing
> -------
> 
> Compiles; when there is no camera, the message appears, once you add a camera, it disappears and deleting all cameras makes the message show up again.
> 
> 
> Thanks,
> 
> Kai Uwe
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20110727/088fd083/attachment.htm