[Kde-graphics-devel] Re: Review Request: Indication that there is no camera set up for Kamera's KCM (similar to Bluedevil)
Aurélien Gâteau
agateau at kde.org
Thu Jul 28 11:10:52 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102102/#review5157
-----------------------------------------------------------
Maybe you can take advantage of the new KMessageWidget class to implement this? Bluedevil KCM is using it as well.
kcontrol/kamera.cpp
<http://git.reviewboard.kde.org/r/102102/#comment4653>
Can be simplified to: "bool hasCamera = false"
Then replace "CameraCount++" in the loop with "hasCamera = true"
Then replace "if (CameraCount == 0)" with "if (!hasCamera)"
- Aurélien
On July 27, 2011, 5:16 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102102/
> -----------------------------------------------------------
>
> (Updated July 27, 2011, 5:16 p.m.)
>
>
> Review request for KDE Graphics.
>
>
> Summary
> -------
>
> In Bluedevil you have a nice message indicating that no Bluetooth Device has yet been added. This patch implements the same behavior for Kamera's KCM.
> Screenshot: http://privat.broulik.de/kamerakcmpatch.png
>
>
> Diffs
> -----
>
> kcontrol/kamera.h abb766f
> kcontrol/kamera.cpp ad3cf2e
>
> Diff: http://git.reviewboard.kde.org/r/102102/diff
>
>
> Testing
> -------
>
> Compiles; when there is no camera, the message appears, once you add a camera, it disappears and deleting all cameras makes the message show up again.
>
>
> Thanks,
>
> Kai Uwe
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20110728/912b46ed/attachment-0001.htm
More information about the Kde-graphics-devel
mailing list