[Kde-graphics-devel] Re: Review Request: Indication that there is no camera set up for Kamera's KCM (similar to Bluedevil)

Kai Uwe Broulik kde at privat.broulik.de
Wed Jul 27 19:16:38 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102102/
-----------------------------------------------------------

(Updated July 27, 2011, 5:16 p.m.)


Review request for KDE Graphics.


Changes
-------

Corrected indentation (why do they use tabulators here again while everywhere else 4 spaces are used? …)


Summary
-------

In Bluedevil you have a nice message indicating that no Bluetooth Device has yet been added. This patch implements the same behavior for Kamera's KCM.
Screenshot: http://privat.broulik.de/kamerakcmpatch.png


Diffs (updated)
-----

  kcontrol/kamera.h abb766f 
  kcontrol/kamera.cpp ad3cf2e 

Diff: http://git.reviewboard.kde.org/r/102102/diff


Testing
-------

Compiles; when there is no camera, the message appears, once you add a camera, it disappears and deleting all cameras makes the message show up again.


Thanks,

Kai Uwe

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20110727/60a75970/attachment.htm 


More information about the Kde-graphics-devel mailing list