D10889: Summary: SpiderSolitaire: Check if there exists a card below before accessing it

[Albert Astals Cid]

aacid added a comment.


  In D10889#215015 <https://phabricator.kde.org/D10889#215015>, @fabiank wrote:
  
  > This solves  maybe the issue which appeared in BUG: 389540. At least, I don't get any invalid access warnings from asan anymore. However, the logic of the search is somewhat complex, so I'm not 100% sure that the correct branch is taken with the new access checks. Someone more familiar with the code might want to take a look at it.
  
  
  I'm afraid we don't really have much people familiar with the code around anymore. I'll try to give it a look at some point. You were able to reproduce the crash/asan warning each time?

REPOSITORY
  R410 KPatience

REVISION DETAIL
  https://phabricator.kde.org/D10889

To: fabiank, #kde_games
Cc: aacid, #kde_games
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20180228/3157d09a/attachment.html>