D10889: Summary: SpiderSolitaire: Check if there exists a card below before accessing it

[Fabian Kosmale]

fabiank added a comment.


  I should add that KPatience relies on the Wp pointing one field before an array (which happens for instance Solver::unpack_position when strecpy returns 0, as the pile is empty). This apparently works with most compilers, but technically it's UB according to §5.7, 4 of the C++ standard (N4296). However, fixing this would require a large amount of refactoring.

REPOSITORY
  R410 KPatience

REVISION DETAIL
  https://phabricator.kde.org/D10889

To: fabiank, #kde_games
Cc: #kde_games
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20180227/b3e43416/attachment.html>