D10889: Summary: SpiderSolitaire: Check if there exists a card below before accessing it

[Fabian Kosmale]

fabiank added a comment.


  I always got the an asan abort  due to the missing checks (the solver would always execute the code and dereference non-allocated memory ). Now, without asan and without the patches, I didn't get any crashes in a debug build, and occasionally crashes with RelWithDeb. I didn't get any crashes with RelWithDeb and my patches, though of course there could be other crab sources.
  
  As I commented before, there's still some UB in the code,and unfortunately that's not easy to solve.

REPOSITORY
  R410 KPatience

REVISION DETAIL
  https://phabricator.kde.org/D10889

To: fabiank, #kde_games
Cc: aacid, #kde_games
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20180228/20a2a503/attachment.html>