Review Request 129238: fix theme selector theme lookup

Harald Sitter sitter at kde.org
Sun Oct 23 22:11:26 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129238/
-----------------------------------------------------------

(Updated Oct. 23, 2016, 10:11 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Games.


Changes
-------

Submitted with commit 42897f89a03c2f46ff388df688f9a23675688908 by Albert Astals Cid on behalf of Harald Sitter to branch Applications/16.08.


Repository: libkdegames


Description
-------

knewstuff puts downloaded assets into subdirs like
`.local/share/kblocks/themes/brlublur-hotstuff-access/` which we found
correctly using a subdir iterator, but then failed to preserve the subdir
portion for later loading through KGameTheme in the same function.
to make sure KGameTheme can properly resolve the full path we need to pass
the desktop file path *relative* to data dir we found it in.

CHANGELOG: fix theme selector theme lookup


Diffs
-----

  libkdegamesprivate/kgamethemeselector.cpp 51a9f81d9886f38c56845e3730c50b56accdf95c 

Diff: https://git.reviewboard.kde.org/r/129238/diff/


Testing
-------

theme downloads correctly, then listed in selector, can be applied as theme, gets loaded, still loaded on app restart


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20161023/0237ffeb/attachment.html>


More information about the kde-games-devel mailing list