Review Request 129238: fix theme selector theme lookup
Albert Astals Cid
aacid at kde.org
Sun Oct 23 22:11:01 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129238/#review100225
-----------------------------------------------------------
Ship it!
Ship It!
- Albert Astals Cid
On Oct. 21, 2016, 2:17 p.m., Harald Sitter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129238/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2016, 2:17 p.m.)
>
>
> Review request for KDE Games.
>
>
> Repository: libkdegames
>
>
> Description
> -------
>
> knewstuff puts downloaded assets into subdirs like
> `.local/share/kblocks/themes/brlublur-hotstuff-access/` which we found
> correctly using a subdir iterator, but then failed to preserve the subdir
> portion for later loading through KGameTheme in the same function.
> to make sure KGameTheme can properly resolve the full path we need to pass
> the desktop file path *relative* to data dir we found it in.
>
> CHANGELOG: fix theme selector theme lookup
>
>
> Diffs
> -----
>
> libkdegamesprivate/kgamethemeselector.cpp 51a9f81d9886f38c56845e3730c50b56accdf95c
>
> Diff: https://git.reviewboard.kde.org/r/129238/diff/
>
>
> Testing
> -------
>
> theme downloads correctly, then listed in selector, can be applied as theme, gets loaded, still loaded on app restart
>
>
> Thanks,
>
> Harald Sitter
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20161023/da618fdd/attachment.html>
More information about the kde-games-devel
mailing list