Review Request 129295: do not needlessly register kblocks on the session bus

Harald Sitter sitter at kde.org
Mon Oct 31 11:40:42 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129295/
-----------------------------------------------------------

Review request for KDE Games and Aleix Pol Gonzalez.


Repository: kblocks


Description
-------

kblocks provides no service, so it having startuptype multi is not
beneficial to anyone (multi means ktoolinvocation will wait for
registration before considering the service started).
without multi startup there is no reason to use dbusaddons at all as there
is no reason to register on dbus as kblocks has no actual dbus API 3rd
parties should use. so, remove all of dbus.


Diffs
-----

  CMakeLists.txt d90453d8da079aeaba13b6a129cccb48b56a5ec6 
  main.cpp 349e22e0b4beb384e2fdd78d20abdd948d5ef9e9 
  org.kde.kblocks.desktop 042cb40afdd2474eafb4c9284dcaa16fdf33de4b 

Diff: https://git.reviewboard.kde.org/r/129295/diff/


Testing
-------

builds, doesn't use dbus anymore, plasma and krunner can still start it without problems


Thanks,

Harald Sitter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20161031/d7e82898/attachment.html>


More information about the kde-games-devel mailing list