[Kde-games-devel] Review Request 127370: KBlocks: Enable sounds

[Julian Helfferich]

> On March 20, 2016, 9:32 a.m., Frederik Schwarzer wrote:
> > KBlocksScene.cpp, lines 318-321
> > <https://git.reviewboard.kde.org/r/127370/diff/1/?file=449986#file449986line318>
> >
> >     Hmm, does it sound weird otherwise?
> >     Too much noise in the demo?

The BockRemove sound is rather long (1.6 seconds) and I found the soundscape to be too crowded when the sound was played for both the player and the AI. I also found it more consistent to play sounds only for the human player.

I know, this is a matter of personal preference. Maybe it would be best to allow the player to configure sounds, with the current approach being the default? Sounds like some work, however...


- Julian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127370/#review93755
-----------------------------------------------------------


On March 14, 2016, 2:10 a.m., Julian Helfferich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127370/
> -----------------------------------------------------------
> 
> (Updated March 14, 2016, 2:10 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Bugs: 319372
>     http://bugs.kde.org/show_bug.cgi?id=319372
> 
> 
> Repository: kblocks
> 
> 
> Description
> -------
> 
> Enable sounds in KBlocks. The sounds are only played for the human player in Human vs. AI matches. For the "BlockMove" and "BlockDrop" sounds, the respective keyboard inputs emit a new signal blockMoved() or blockDropped() signal which are connected to the new playMoveSound() and playDropSound() slots. The BlockRemove sound is played when one or more lines are removed.
> 
> 
> Diffs
> -----
> 
>   KBlocksKeyboardPlayer.h cc78472 
>   KBlocksKeyboardPlayer.cpp cf6225f 
>   KBlocksScene.h 7280710 
>   KBlocksScene.cpp c84d68e 
>   KBlocksWin.cpp a3c83f2 
> 
> Diff: https://git.reviewboard.kde.org/r/127370/diff/
> 
> 
> Testing
> -------
> 
> * Played single game -> Sounds play correctly.
> * Played Human vs AI -> Sounds play only for human player (as intended).
> * Turned off/on sounds -> Sounds off/on correctly.
> 
> 
> Thanks,
> 
> Julian Helfferich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160321/2985bf26/attachment-0001.html>