[Kde-games-devel] Review Request 127399: [kjumpingcube] Remove unused deps, unbreak startup

[Julian Helfferich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127399/#review93748
-----------------------------------------------------------


Ship it!




About the fix of the startup bug, there is a very similar bug in KBlocks, bug 357408 [1]. Do you think it can be fixed in the same way? Honestly, I am a little bit out of my depth with the KDBusAddons and KDEInit...

Maybe you could also have a look at bug 344895 [2] which says that (at least) kbreakout and bomber show similar problems on startup.

[1] https://bugs.kde.org/show_bug.cgi?id=357408
[2] https://bugs.kde.org/show_bug.cgi?id=344895

- Julian Helfferich


On March 16, 2016, 10:35 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127399/
> -----------------------------------------------------------
> 
> (Updated March 16, 2016, 10:35 p.m.)
> 
> 
> Review request for KDE Games, Ian Wadham and Frederik Schwarzer.
> 
> 
> Bugs: 357409
>     http://bugs.kde.org/show_bug.cgi?id=357409
> 
> 
> Repository: kjumpingcube
> 
> 
> Description
> -------
> 
> Removed unused deps. Added a second commit that unbreaks startup.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a53ac48b795a31855fa2518135d245563ed6c55b 
>   main.cpp 46a8759c8cecf9b02c7ea91ea7d093e56ea715b0 
> 
> Diff: https://git.reviewboard.kde.org/r/127399/diff/
> 
> 
> Testing
> -------
> 
> Builds fine without these deps.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160320/70da1445/attachment-0001.html>