[Kde-games-devel] Review Request 127399: [kjumpingcube] Remove unused deps, unbreak startup

[Andreas Sturmlechner]

> On March 20, 2016, 3:47 a.m., Ian Wadham wrote:
> > CMakeLists.txt, line 10
> > <https://git.reviewboard.kde.org/r/127399/diff/1-2/?file=453388#file453388line10>
> >
> >     Do we need Qml and Quick? KJumpingCube does not use QML (Author's note).

I've looked into it and decided to leave them like that. Even if the games do not use them, unfortunately configure requires them because of libkdegames.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127399/#review93747
-----------------------------------------------------------


On March 16, 2016, 10:35 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127399/
> -----------------------------------------------------------
> 
> (Updated March 16, 2016, 10:35 p.m.)
> 
> 
> Review request for KDE Games, Ian Wadham and Frederik Schwarzer.
> 
> 
> Bugs: 357409
>     http://bugs.kde.org/show_bug.cgi?id=357409
> 
> 
> Repository: kjumpingcube
> 
> 
> Description
> -------
> 
> Removed unused deps. Added a second commit that unbreaks startup.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a53ac48b795a31855fa2518135d245563ed6c55b 
>   main.cpp 46a8759c8cecf9b02c7ea91ea7d093e56ea715b0 
> 
> Diff: https://git.reviewboard.kde.org/r/127399/diff/
> 
> 
> Testing
> -------
> 
> Builds fine without these deps.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160320/3aab91ba/attachment.html>