[Kde-games-devel] Review Request 127399: [kjumpingcube] Remove unused deps, unbreak startup
Frederik Schwarzer
schwarzer at kde.org
Sun Mar 20 10:19:05 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127399/#review93762
-----------------------------------------------------------
main.cpp (line 82)
<https://git.reviewboard.kde.org/r/127399/#comment63912>
Just out of curiosity. What made you use KDBus like that? Only kpat is using it like this. All other games just say "KDBusService service;".
- Frederik Schwarzer
On March 16, 2016, 10:35 p.m., Andreas Sturmlechner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127399/
> -----------------------------------------------------------
>
> (Updated March 16, 2016, 10:35 p.m.)
>
>
> Review request for KDE Games, Ian Wadham and Frederik Schwarzer.
>
>
> Bugs: 357409
> http://bugs.kde.org/show_bug.cgi?id=357409
>
>
> Repository: kjumpingcube
>
>
> Description
> -------
>
> Removed unused deps. Added a second commit that unbreaks startup.
>
>
> Diffs
> -----
>
> CMakeLists.txt a53ac48b795a31855fa2518135d245563ed6c55b
> main.cpp 46a8759c8cecf9b02c7ea91ea7d093e56ea715b0
>
> Diff: https://git.reviewboard.kde.org/r/127399/diff/
>
>
> Testing
> -------
>
> Builds fine without these deps.
>
>
> Thanks,
>
> Andreas Sturmlechner
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160320/8e7d85ad/attachment.html>
More information about the kde-games-devel
mailing list