[Kde-games-devel] Review Request 127284: KBlocks: Port sound to KgSound

[Frederik Schwarzer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127284/#review93180
-----------------------------------------------------------



Nice. :)
Could you also edit https://community.kde.org/KDE_Games/Porting accordingly after you committed this.


KBlocksSound.h (line 19)
<https://git.reviewboard.kde.org/r/127284/#comment63532>

    Prefer enum class over older enum type.
    Just write "enum class Sound {" and get type-safety for free. :)



KBlocksSound.h (line 26)
<https://git.reviewboard.kde.org/r/127284/#comment63531>

    Only constructors which can be called with one parameter should be marked explicit.



KBlocksSound.cpp (lines 44 - 50)
<https://git.reviewboard.kde.org/r/127284/#comment63533>

    I would probably use a switch/case here. Purely from the logics point of view it feels a bit weird to say "OK, if none of the sounds mentioned above matched, just play that other sound we have". A switch/case might make the intent of the code more obvious.
    
    Note: If you use enum class as mentioned above, the compiler needs you to write "Sounds::BlockFall" here.


- Frederik Schwarzer


On March 5, 2016, 4:35 a.m., Julian Helfferich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127284/
> -----------------------------------------------------------
> 
> (Updated March 5, 2016, 4:35 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: kblocks
> 
> 
> Description
> -------
> 
> Port sound in KBlocksSound from Phonon to KgSound. Note that neither before nor after this port sounds are played (the KBlocksSound::playSound() function is not called). I have also re-enabled the sound and will post the patch here once the port to KgSound is approved and pushed.
> 
> The new KBlocksSound uses the sounds from the sounds/ directory. Previously it was intended (at least it seams so to me) that the sound is part of the theme. However, there are only two of three sounds in the themes/ directory (default theme). Thus, unless there are any themed sounds, I suggest to simply use the sounds from the sounds/ directory.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 38fdfd3 
>   KBlocksScene.cpp 07cd457 
>   KBlocksSound.h dc02775 
>   KBlocksSound.cpp 1346bc6 
>   sounds/CMakeLists.txt PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127284/diff/
> 
> 
> Testing
> -------
> 
> The testing were done for this patch plus the next patch enabling the sounds.
>  
> * Played single game -> Sounds play correctly.
> * Played Human vs AI -> Sounds play only for human player (as intended).
> * Turned off/on sounds -> Sounds off/on correctly.
> 
> 
> Thanks,
> 
> Julian Helfferich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160305/a3b43672/attachment.html>